Changeset a97b9ed for src/GenPoly/BoxNew.cpp

Timestamp:

Oct 16, 2023, 8:09:51 AM (14 months ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

master

Children:

2bf46a5, 54e59dd, 61e5d99

Parents:

946a6e4 (diff), 8cbe732 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

File:

• src/GenPoly/BoxNew.cpp (modified) (16 diffs)

src/GenPoly/BoxNew.cpp

@@ -94 +94 @@
 
 /// Adds parameters for otype size and alignment to a function type.
-void addOTypeParams(
-                ast::FunctionDecl * decl,
+void addSTypeParams(
+                ast::vector<ast::DeclWithType> & params,
                 ast::vector<ast::TypeDecl> const & sizedParams ) {
-        // TODO: Can we fold this into buildLayoutFunction to avoid rebuilding?
-        ast::FunctionType * type = ast::mutate( decl->type.get() );
         for ( ast::ptr<ast::TypeDecl> const & sizedParam : sizedParams ) {
                 ast::TypeInstType inst( sizedParam );
                 std::string paramName = Mangle::mangleType( &inst );
-                decl->params.emplace_back( new ast::ObjectDecl(
+                params.emplace_back( new ast::ObjectDecl(
                         sizedParam->location,
                         sizeofName( paramName ),
                         makeSizeAlignType()
                 ) );
-                type->params.emplace_back( makeSizeAlignType() );
-                decl->params.emplace_back( new ast::ObjectDecl(
+                params.emplace_back( new ast::ObjectDecl(
                         sizedParam->location,
                         alignofName( paramName ),
                         makeSizeAlignType()
                 ) );
-                type->params.emplace_back( makeSizeAlignType() );
-        }
-        decl->type = type;
+        }
 }
 
@@ -129 +124 @@
 };
 
-// TODO: Is there a better way to handle the different besides a flag?
 LayoutData buildLayoutFunction(
                 CodeLocation const & location, ast::AggregateDecl const * aggr,
+                ast::vector<ast::TypeDecl> const & sizedParams,
                 bool isInFunction, bool isStruct ) {
         ast::ObjectDecl * sizeParam = new ast::ObjectDecl(
@@ -153 +148 @@
                 params.push_back( offsetParam );
         }
+        addSTypeParams( params, sizedParams );
 
         // Routines at global scope marked "static" to prevent multiple
@@ -238 +234 @@
 
         // Build layout function signature.
-        LayoutData layout =
-                buildLayoutFunction( location, decl, isInFunction(), true );
+        LayoutData layout = buildLayoutFunction(
+                location, decl, sizedParams, isInFunction(), true );
         ast::FunctionDecl * layoutDecl = layout.function;
         // Also return these or extract them from the parameter list?
@@ -246 +242 @@
         ast::ObjectDecl const * offsetofParam = layout.offsetofParam;
         assert( nullptr != layout.offsetofParam );
-        addOTypeParams( layoutDecl, sizedParams );
 
         // Calculate structure layout in function body.
@@ -313 +308 @@
 
         // Build layout function signature.
-        LayoutData layout =
-                buildLayoutFunction( location, decl, isInFunction(), false );
+        LayoutData layout = buildLayoutFunction(
+                location, decl, sizedParams, isInFunction(), false );
         ast::FunctionDecl * layoutDecl = layout.function;
         // Also return these or extract them from the parameter list?
@@ -320 +315 @@
         ast::ObjectDecl const * alignofParam = layout.alignofParam;
         assert( nullptr == layout.offsetofParam );
-        addOTypeParams( layoutDecl, sizedParams );
 
         // Calculate union layout in function body.
@@ -641 +635 @@
         // the variable can be reused as a parameter to the call rather than
         // creating a new temporary variable. Previously this step was an
-        // optimization, but
-        // ...
-        // with the introduction of tuples and UniqueExprs, it is necessary to
-        // ensure that they use the same variable.
+        // optimization, but with the introduction of tuples and UniqueExprs,
+        // it is necessary to ensure that they use the same variable.
         // Essentially, looking for pattern:
         // (x=f(...), x)
@@ -689 +681 @@
         // the distinction between _conc_T30 and T3(int)) concRetType may not be
         // a good name in one or both of these places.
-        // TODO A more appropriate name change is welcome.
         if ( dynRetType ) {
                 ast::Type const * result = mutExpr->result;
@@ -698 +689 @@
         } else if ( needsAdapter( function, scopeTypeVars )
                         && !needsAdapter( function, exprTypeVars ) ) {
-                // TODO:
-                // The !needsAdapter check may be incorrect. It seems there is some
-                // situation where an adapter is applied where it shouldn't be,
-                // and this fixes it for some case. More investigation is needed.
-
                 // Change the application so it calls the adapter rather than the
                 // passed function.
@@ -1774 +1760 @@
         /// Adds type parameters to the layout call; will generate the
         /// appropriate parameters if needed.
-        void addOTypeParamsToLayoutCall(
+        void addSTypeParamsToLayoutCall(
                 ast::UntypedExpr * layoutCall,
                 const ast::vector<ast::Type> & otypeParams );
@@ -2014 +2000 @@
                 ast::MemberExpr const * expr ) {
         // Only mutate member expressions for polymorphic types.
-        int typeDepth;
         ast::Type const * objectType = hasPolyBase(
-                expr->aggregate->result, scopeTypeVars, &typeDepth
+                expr->aggregate->result, scopeTypeVars
         );
         if ( !objectType ) return expr;
@@ -2094 +2079 @@
         }
         // MemberExpr was converted to pointer + offset; and it is not valid C to
-        // take the address of an addition, so stript the address-of.
+        // take the address of an addition, so strip away the address-of.
         // It also preserves the env value.
         return ast::mutate_field( expr->arg.get(), &ast::Expr::env, expr->env );
@@ -2295 +2280 @@
                                 } );
 
-                        addOTypeParamsToLayoutCall( layoutCall, sizedParams );
+                        addSTypeParamsToLayoutCall( layoutCall, sizedParams );
 
                         stmtsToAddBefore.emplace_back(
@@ -2336 +2321 @@
                         } );
 
-                addOTypeParamsToLayoutCall( layoutCall, sizedParams );
+                addSTypeParamsToLayoutCall( layoutCall, sizedParams );
 
                 stmtsToAddBefore.emplace_back(
@@ -2346 +2331 @@
 }
 
-void PolyGenericCalculator::addOTypeParamsToLayoutCall(
+void PolyGenericCalculator::addSTypeParamsToLayoutCall(
                 ast::UntypedExpr * layoutCall,
                 const ast::vector<ast::Type> & otypeParams ) {