Changeset 69c5c00 for libcfa/src/concurrency

Timestamp:

Oct 7, 2020, 6:08:35 PM (5 years ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

6fbe9a5

Parents:

41b8ea4

Message:

Rework exceptions mark_exception -> get_exception_vtable and the needed follow up.

Location:

libcfa/src/concurrency

Files:

• coroutine.cfa (modified) (3 diffs)
• coroutine.hfa (modified) (3 diffs)

libcfa/src/concurrency/coroutine.cfa

@@ -47 +47 @@
 
 //-----------------------------------------------------------------------------
-FORALL_DATA_INSTANCE(CoroutineCancelled,
-                (dtype coroutine_t | sized(coroutine_t)), (coroutine_t))
+FORALL_DATA_INSTANCE(CoroutineCancelled, (dtype coroutine_t), (coroutine_t))
 
 struct __cfaehm_node {
@@ -59 +58 @@
 void mark_exception(CoroutineCancelled(T) *) {}
 
-forall(dtype T | sized(T))
+forall(dtype T)
 void copy(CoroutineCancelled(T) * dst, CoroutineCancelled(T) * src) {
         dst->the_coroutine = src->the_coroutine;
@@ -77 +76 @@
         exception_t * except = (exception_t *)(1 + (__cfaehm_node *)desc->cancellation);
 
+        // TODO: Remove explitate vtable set once trac#186 is fixed.
         CoroutineCancelled(T) except;
+        except.virtual_table = &get_exception_vtable(&except);
         except.the_coroutine = &cor;
         except.the_exception = except;

libcfa/src/concurrency/coroutine.hfa

@@ -22 +22 @@
 //-----------------------------------------------------------------------------
 // Exception thrown from resume when a coroutine stack is cancelled.
-// Should not have to be be sized (see trac #196).
-FORALL_DATA_EXCEPTION(CoroutineCancelled,
-                (dtype coroutine_t | sized(coroutine_t)), (coroutine_t)) (
+FORALL_DATA_EXCEPTION(CoroutineCancelled, (dtype coroutine_t), (coroutine_t)) (
         coroutine_t * the_coroutine;
         exception_t * the_exception;
@@ -30 +28 @@
 
 forall(dtype T)
-void mark_exception(CoroutineCancelled(T) *);
-
-forall(dtype T | sized(T))
 void copy(CoroutineCancelled(T) * dst, CoroutineCancelled(T) * src);
 
@@ -42 +37 @@
 // Anything that implements this trait can be resumed.
 // Anything that is resumed is a coroutine.
-trait is_coroutine(dtype T | sized(T)
-                | is_resumption_exception(CoroutineCancelled(T))
-                | VTABLE_ASSERTION(CoroutineCancelled, (T))) {
+trait is_coroutine(dtype T
+                | is_resumption_exception(CoroutineCancelled(T),
+                        CoroutineCancelled_vtable(T))) {
         void main(T & this);
         $coroutine * get_coroutine(T & this);