Incorrect bit shift warning

[Thierry Delisle]

The following code:

extern "C" {
#include <sys/sysmacros.h>
}

int main() { return 0; }

produces the following warning

/usr/include/x86_64-linux-gnu/sys/sysmacros.h: In function ‘gnu_dev_major’:
/usr/include/x86_64-linux-gnu/sys/sysmacros.h:41:145: warning: right shift count >= width of type [-Wshift-count-overflow]
   return ((__dev >> 8) & 0xfff) | ((unsigned int) (__dev >> 32) & ~0xfff);

Command used :

cfa-1.0 test.cfa -Wall -Wextra -O2 

[a3moss]

Under -O2 the preprocessor generates a body for gnu_dev_major that it does not generate at -O0.

[a3moss]

Shorter test case (works on O0 as well):

int main() {
	unsigned long long dev = 0;
	unsigned ret = (unsigned)(dev >> 32);
}

[a3moss]

Backed out change to CastExpr resolution that changed cast costs; concurrently removed specialization cost from return types in new cost model.