Changeset fee651f

Timestamp:

Jan 29, 2018, 4:03:04 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

5a73f0f

Parents:

ebcb7ba

Message:

Refactor AlternativeFinder? handling of LogicalExpr? and RangeExpr? to greatly reduce the number of unnecessary recursive calls

File:

• src/ResolvExpr/AlternativeFinder.cc (modified) (2 diffs)

src/ResolvExpr/AlternativeFinder.cc

@@ -1544 +1544 @@
                 AlternativeFinder firstFinder( indexer, env );
                 firstFinder.findWithAdjustment( logicalExpr->get_arg1() );
+                if ( firstFinder.alternatives.empty() ) return;
+                AlternativeFinder secondFinder( indexer, env );
+                secondFinder.findWithAdjustment( logicalExpr->get_arg2() );
+                if ( secondFinder.alternatives.empty() ) return;
                 for ( AltList::const_iterator first = firstFinder.alternatives.begin(); first != firstFinder.alternatives.end(); ++first ) {
-                        AlternativeFinder secondFinder( indexer, first->env );
-                        secondFinder.findWithAdjustment( logicalExpr->get_arg2() );
                         for ( AltList::const_iterator second = secondFinder.alternatives.begin(); second != secondFinder.alternatives.end(); ++second ) {
+                                TypeEnvironment compositeEnv;
+                                compositeEnv.simpleCombine( first->env );
+                                compositeEnv.simpleCombine( second->env );
+
                                 LogicalExpr *newExpr = new LogicalExpr( first->expr->clone(), second->expr->clone(), logicalExpr->get_isAnd() );
-                                alternatives.push_back( Alternative( newExpr, second->env, first->cost + second->cost ) );
+                                alternatives.push_back( Alternative( newExpr, compositeEnv, first->cost + second->cost ) );
                         }
                 }
@@ -1609 +1615 @@
                 AlternativeFinder firstFinder( indexer, env );
                 firstFinder.findWithAdjustment( rangeExpr->get_low() );
+                if ( firstFinder.alternatives.empty() ) return;
+                AlternativeFinder secondFinder( indexer, env );
+                secondFinder.findWithAdjustment( rangeExpr->get_high() );
+                if ( secondFinder.alternatives.empty() ) return;
                 for ( AltList::const_iterator first = firstFinder.alternatives.begin(); first != firstFinder.alternatives.end(); ++first ) {
-                        AlternativeFinder secondFinder( indexer, first->env );
-                        secondFinder.findWithAdjustment( rangeExpr->get_high() );
                         for ( AltList::const_iterator second = secondFinder.alternatives.begin(); second != secondFinder.alternatives.end(); ++second ) {
+                                TypeEnvironment compositeEnv;
+                                compositeEnv.simpleCombine( first->env );
+                                compositeEnv.simpleCombine( second->env );
                                 OpenVarSet openVars;
                                 AssertionSet needAssertions, haveAssertions;
-                                Alternative newAlt( 0, second->env, first->cost + second->cost );
+                                Alternative newAlt( 0, compositeEnv, first->cost + second->cost );
                                 Type* commonType = nullptr;
                                 if ( unify( first->expr->get_result(), second->expr->get_result(), newAlt.env, needAssertions, haveAssertions, openVars, indexer, commonType ) ) {