Changes in / [6380f78:f4c2f1a]

Location:

src

Files:

• AST/Expr.cpp (modified) (2 diffs)
• AST/GenericSubstitution.cpp (deleted)
• AST/GenericSubstitution.hpp (deleted)
• AST/Node.hpp (modified) (1 diff)
• AST/Pass.hpp (modified) (1 diff)
• AST/TypeSubstitution.hpp (modified) (3 diffs)
• AST/module.mk (modified) (1 diff)
• AST/porting.md (modified) (3 diffs)
• Makefile.in (modified) (4 diffs)

src/AST/Expr.cpp

@@ -20 +20 @@
 #include <vector>
 
-#include "GenericSubstitution.hpp"
 #include "Stmt.hpp"
 #include "Type.hpp"
-#include "TypeSubstitution.hpp"
 #include "Common/utility.h"
 #include "Common/SemanticError.h"
@@ -159 +157 @@
         assert( aggregate->result );
 
-        // take ownership of member type
-        Type * res = result.set_and_mutate( mem->get_type() );
-        // substitute aggregate generic parameters into member type
-        genericSubsitution( aggregate->result ).apply( res );
-        // ensure lvalue and appropriate restrictions from aggregate type
-        res->set_lvalue( true );
-        res->qualifiers |= aggregate->result->qualifiers;
-        // ensure changes propegated back into result
-        result = res;
+        assert(!"unimplemented; need TypeSubstitution, genericSubstitution");
 }
 

src/AST/Node.hpp

@@ -94 +94 @@
 std::ostream& operator<< ( std::ostream& out, const Node * node );
 
-/// Call a visitor on a possibly-null node
-template<typename node_t>
-auto maybe_accept( const node_t * n, Visitor & v ) -> decltype( n->accept(v) ) {
-        return n ? n->accept( v ) : nullptr;
-}
-
 /// Base class for the smart pointer types
 /// should never really be used.

src/AST/Pass.hpp

@@ -223 +223 @@
 };
 
-/// Apply a pass to an entire translation unit
 template<typename pass_t>
 void accept_all( std::list< ast::ptr<ast::Decl> > &, ast::Pass<pass_t> & visitor );

src/AST/TypeSubstitution.hpp

@@ -25 +25 @@
 #include "Fwd.hpp"        // for UniqueId
 #include "ParseNode.hpp"
-#include "Type.hpp"       
+#include "Type.hpp"       // for ptr<Type>
 #include "Common/SemanticError.h"  // for SemanticError
 #include "Visitor.hpp"
@@ -165 +165 @@
         assert( input );
         Pass<Substituter> sub( *this, false );
-        input = strict_dynamic_cast< SynTreeClass * >( input->accept( sub ) );
+        input = dynamic_cast< SynTreeClass * >( input->acceptMutator( sub ) );
+        assert( input );
 ///     std::cerr << "substitution result is: ";
 ///     newType->print( std::cerr );
@@ -176 +177 @@
         assert( input );
         Pass<Substituter> sub( *this, true );
-        input = strict_dynamic_cast< SynTreeClass * >( input->accept( sub ) );
+        input = dynamic_cast< SynTreeClass * >( input->acceptMutator( sub ) );
+        assert( input );
 ///     std::cerr << "substitution result is: ";
 ///     newType->print( std::cerr );

src/AST/module.mk

@@ -21 +21 @@
         AST/DeclReplacer.cpp \
         AST/Expr.cpp \
-        AST/GenericSubstitution.cpp \
         AST/Init.cpp \
         AST/LinkageSpec.cpp \

src/AST/porting.md

@@ -38 +38 @@
 
 `N->print(std::ostream&)` is a visitor now, port these methods to `ast::Print` class
-* **TODO** `Declaration::printShort` should also be integrated
+* **TODO** write this visitor
+* **TODO** write `std::ostream& operator<< ( std::ostream& out, const Node* node )` in `Node.hpp` in terms of `ast::Print`
+* `Declaration::printShort` should also be integrated
 
 `clone` is private to `Node` now
@@ -206 +208 @@
 
 `CompoundStmt`
+* **TODO** port copy operator
+  * Needs to be an almost-shallow clone, where the declarations are cloned only if needed
+  * **TODO** port `DeclReplacer`
 * Still a `std::list` for children, rather than `std::vector`
   * allows more-efficient splicing for purposes of later code generation
@@ -224 +229 @@
   * `getAggr()` => `aggr()`
     * also now returns `const AggregateDecl *`
-* `genericSubstitution()` moved to own visitor in `AST/GenericSubstitution.hpp`
+* `genericSubstitution()` moved to own visitor in `AST/GenericSubstitution.hpp` **TODO** write
 
 `BasicType`

src/Makefile.in

@@ -167 +167 @@
 am__objects_1 = AST/Attribute.$(OBJEXT) AST/Convert.$(OBJEXT) \
         AST/Decl.$(OBJEXT) AST/DeclReplacer.$(OBJEXT) \
-        AST/Expr.$(OBJEXT) AST/GenericSubstitution.$(OBJEXT) \
-        AST/Init.$(OBJEXT) AST/LinkageSpec.$(OBJEXT) \
-        AST/Node.$(OBJEXT) AST/Pass.$(OBJEXT) AST/Print.$(OBJEXT) \
-        AST/Stmt.$(OBJEXT) AST/Type.$(OBJEXT) \
-        AST/TypeSubstitution.$(OBJEXT)
+        AST/Expr.$(OBJEXT) AST/Init.$(OBJEXT) \
+        AST/LinkageSpec.$(OBJEXT) AST/Node.$(OBJEXT) \
+        AST/Pass.$(OBJEXT) AST/Print.$(OBJEXT) AST/Stmt.$(OBJEXT) \
+        AST/Type.$(OBJEXT) AST/TypeSubstitution.$(OBJEXT)
 am__objects_2 = CodeGen/CodeGenerator.$(OBJEXT) \
         CodeGen/FixMain.$(OBJEXT) CodeGen/GenType.$(OBJEXT) \
@@ -575 +574 @@
         AST/DeclReplacer.cpp \
         AST/Expr.cpp \
-        AST/GenericSubstitution.cpp \
         AST/Init.cpp \
         AST/LinkageSpec.cpp \
@@ -741 +739 @@
         AST/$(DEPDIR)/$(am__dirstamp)
 AST/Expr.$(OBJEXT): AST/$(am__dirstamp) AST/$(DEPDIR)/$(am__dirstamp)
-AST/GenericSubstitution.$(OBJEXT): AST/$(am__dirstamp) \
-        AST/$(DEPDIR)/$(am__dirstamp)
 AST/Init.$(OBJEXT): AST/$(am__dirstamp) AST/$(DEPDIR)/$(am__dirstamp)
 AST/LinkageSpec.$(OBJEXT): AST/$(am__dirstamp) \
@@ -1177 +1173 @@
 @AMDEP_TRUE@@am__include@ @am__quote@AST/$(DEPDIR)/DeclReplacer.Po@am__quote@
 @AMDEP_TRUE@@am__include@ @am__quote@AST/$(DEPDIR)/Expr.Po@am__quote@
-@AMDEP_TRUE@@am__include@ @am__quote@AST/$(DEPDIR)/GenericSubstitution.Po@am__quote@
 @AMDEP_TRUE@@am__include@ @am__quote@AST/$(DEPDIR)/Init.Po@am__quote@
 @AMDEP_TRUE@@am__include@ @am__quote@AST/$(DEPDIR)/LinkageSpec.Po@am__quote@