Changeset e9a715d3 for src/SynTree/TypeSubstitution.h

Timestamp:

Jan 9, 2018, 4:03:54 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

b8a4f47

Parents:

07c178f0

Message:

Convert TypeSubstitution?'s apply functionality to PassVisitor?

File:

• src/SynTree/TypeSubstitution.h (modified) (5 diffs)

src/SynTree/TypeSubstitution.h

@@ -27 +27 @@
 #include "SynTree/Declaration.h"   // for TypeDecl, Declaration (ptr only)
 #include "SynTree/Expression.h"    // for Expression (ptr only), NameExpr (p...
-#include "SynTree/Mutator.h"       // for Mutator
 #include "SynTree/Type.h"          // for Type, ArrayType (ptr only), BasicT...
 
-class TypeSubstitution : public Mutator {
-        typedef Mutator Parent;
+class TypeSubstitution {
   public:
         TypeSubstitution();
@@ -64 +62 @@
         TypeSubstitution *clone() const { return new TypeSubstitution( *this ); }
   private:
-        virtual Type* mutate(TypeInstType *aggregateUseType);
-        virtual Expression* mutate(NameExpr *nameExpr);
 
-        /// Records type variable bindings from forall-statements
-        template< typename TypeClass > Type *handleType( TypeClass *type );
-        /// Records type variable bindings from forall-statements and instantiations of generic types
-        template< typename TypeClass > Type *handleAggregateType( TypeClass *type );
-
-        virtual Type* mutate(VoidType *basicType);
-        virtual Type* mutate(BasicType *basicType);
-        virtual Type* mutate(PointerType *pointerType);
-        virtual Type* mutate(ArrayType *arrayType);
-        virtual Type* mutate(FunctionType *functionType);
-        virtual Type* mutate(StructInstType *aggregateUseType);
-        virtual Type* mutate(UnionInstType *aggregateUseType);
-        virtual Type* mutate(EnumInstType *aggregateUseType);
-        virtual Type* mutate(TraitInstType *aggregateUseType);
-        virtual Type* mutate(TupleType *tupleType);
-        virtual Type* mutate(VarArgsType *varArgsType);
-        virtual Type* mutate(ZeroType *zeroType);
-        virtual Type* mutate(OneType *oneType);
+        // Mutator that performs the substitution
+        struct Substituter;
 
         // TODO: worry about traversing into a forall-qualified function type or type decl with assertions
@@ -97 +77 @@
         typedef std::map< std::string, Type* > TypeEnvType;
         typedef std::map< std::string, Expression* > VarEnvType;
-        typedef std::set< std::string > BoundVarsType;
         TypeEnvType typeEnv;
         VarEnvType varEnv;
-        BoundVarsType boundVars;
-        int subCount;
-        bool freeOnly;
 };
 
@@ -134 +110 @@
 
 template< typename FormalIterator, typename ActualIterator >
-TypeSubstitution::TypeSubstitution( FormalIterator formalBegin, FormalIterator formalEnd, ActualIterator actualBegin )
-{
+TypeSubstitution::TypeSubstitution( FormalIterator formalBegin, FormalIterator formalEnd, ActualIterator actualBegin ) {
         add( formalBegin, formalEnd, actualBegin );
 }
+
+// include needs to happen after TypeSubstitution is defined so that both TypeSubstitution and
+// PassVisitor are defined before PassVisitor implementation accesses TypeSubstitution internals.
+#include "Common/PassVisitor.h"
+
+// definitition must happen after PassVisitor is included so that WithGuards can be used
+struct TypeSubstitution::Substituter : public WithGuards {
+                Substituter( TypeSubstitution & sub, bool freeOnly ) : sub( sub ), freeOnly( freeOnly ) {}
+
+                Type * postmutate( TypeInstType * aggregateUseType );
+                Expression * postmutate( NameExpr * nameExpr );
+
+                /// Records type variable bindings from forall-statements
+                void premutate( Type * type );
+                /// Records type variable bindings from forall-statements and instantiations of generic types
+                template< typename TypeClass > void handleAggregateType( TypeClass * type );
+
+                void premutate( StructInstType * aggregateUseType );
+                void premutate( UnionInstType * aggregateUseType );
+
+                TypeSubstitution & sub;
+                int subCount = 0;
+                bool freeOnly;
+                typedef std::set< std::string > BoundVarsType;
+                BoundVarsType boundVars;
+};
 
 template< typename SynTreeClass >
 int TypeSubstitution::apply( SynTreeClass *&input ) {
         assert( input );
-        subCount = 0;
-        freeOnly = false;
-        input = dynamic_cast< SynTreeClass *>( input->acceptMutator( *this ) );
+        PassVisitor<Substituter> sub( *this, false );
+        input = dynamic_cast< SynTreeClass * >( input->acceptMutator( sub ) );
         assert( input );
-///     std::cout << "substitution result is: ";
-///     newType->print( std::cout );
-///     std::cout << std::endl;
-        return subCount;
+///     std::cerr << "substitution result is: ";
+///     newType->print( std::cerr );
+///     std::cerr << std::endl;
+        return sub.pass.subCount;
 }
 
@@ -155 +155 @@
 int TypeSubstitution::applyFree( SynTreeClass *&input ) {
         assert( input );
-        subCount = 0;
-        freeOnly = true;
-        input = dynamic_cast< SynTreeClass *>( input->acceptMutator( *this ) );
+        PassVisitor<Substituter> sub( *this, true );
+        input = dynamic_cast< SynTreeClass * >( input->acceptMutator( sub ) );
         assert( input );
-///     std::cout << "substitution result is: ";
-///     newType->print( std::cout );
-///     std::cout << std::endl;
-        return subCount;
+///     std::cerr << "substitution result is: ";
+///     newType->print( std::cerr );
+///     std::cerr << std::endl;
+        return sub.pass.subCount;
 }