Changeset e172f42 for src/ResolvExpr/ConversionCost.cc

Timestamp:

Jun 16, 2023, 9:10:46 AM (2 years ago)

Author:

caparsons <caparson@…>

Branches:

master

Children:

5dbb9f3

Parents:

a0bd9a2 (diff), 62d62db (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'ast-experimental'

File:

• src/ResolvExpr/ConversionCost.cc (modified) (5 diffs)

src/ResolvExpr/ConversionCost.cc

@@ -702 +702 @@
 
         cost = costCalc( refType->base, dst, srcIsLvalue, symtab, env );
+
+        // xxx - should qualifiers be considered in pass-by-value?
+        /*
         if ( refType->base->qualifiers == dst->qualifiers ) {
                 cost.incReference();
@@ -709 +712 @@
                 cost.incUnsafe();
         }
+        */
+        cost.incReference();
 }
 
@@ -792 +797 @@
                         cost.incSign( signMatrix[ ast::BasicType::SignedInt ][ dstAsBasic->kind ] );
                 }
+                // this has the effect of letting any expr such as x+0, x+1 to be typed
+                // the same as x, instead of at least int. are we willing to sacrifice this little
+                // bit of coherence with C?
+                // TODO: currently this does not work when no zero/one overloads exist. Find a fix for it.
+                // cost = Cost::zero;
         } else if ( dynamic_cast< const ast::PointerType * >( dst ) ) {
                 cost = Cost::zero;
                 // +1 for zero_t ->, +1 for disambiguation
                 cost.incSafe( maxIntCost + 2 );
+                // assuming 0p is supposed to be used for pointers?
         }
 }
@@ -804 +815 @@
                 cost = Cost::zero;
         } else if ( const ast::BasicType * dstAsBasic =
-                        dynamic_cast< const ast::BasicType * >( dst ) ) {
+                        dynamic_cast< const ast::BasicType * >( dst ) ) {               
                 int tableResult = costMatrix[ ast::BasicType::SignedInt ][ dstAsBasic->kind ];
                 if ( -1 == tableResult ) {
@@ -813 +824 @@
                         cost.incSign( signMatrix[ ast::BasicType::SignedInt ][ dstAsBasic->kind ] );
                 }
+                
+                // cost = Cost::zero;
         }
 }