Changeset db6f06a for src/libcfa/concurrency/kernel

Timestamp:

Feb 13, 2017, 5:04:43 PM (8 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

ee897e4b

Parents:

75f3522

Message:

Implemented better condition lock to solve race condition on thread/processor termination

File:

• src/libcfa/concurrency/kernel (modified) (4 diffs)

src/libcfa/concurrency/kernel ¶

@@ -27 +27 @@
 
 //-----------------------------------------------------------------------------
+// Locks
+// void lock( simple_lock * );
+// void lock( simple_lock *, spinlock * );
+// void unlock( simple_lock * );
+
+void lock( spinlock * );
+void unlock( spinlock * );
+
+void wait( signal_once * );
+void signal( signal_once * );
+
+//-----------------------------------------------------------------------------
 // Cluster
 struct cluster {
         simple_thread_list ready_queue;
-        // pthread_spinlock_t lock;
+        spinlock lock;
 };
 
@@ -38 +50 @@
 //-----------------------------------------------------------------------------
 // Processor
-enum ProcessorAction { 
-        Reschedule,
-        NoAction
+enum FinishOpCode { No_Action, Release, Schedule, Release_Schedule };
+struct FinishAction {
+        FinishOpCode action_code;
+        thread * thrd;
+        spinlock * lock;
 };
+static inline void ?{}(FinishAction * this) { 
+        this->action_code = No_Action;
+        this->thrd = NULL;
+        this->lock = NULL;
+}
+static inline void ^?{}(FinishAction * this) {}
 
 struct processor {
@@ -49 +69 @@
         thread * current_thread;
         pthread_t kernel_thread;
-        simple_lock lock;
-        volatile bool terminated;
-        ProcessorAction thread_action;
+        
+        signal_once terminated;
+        volatile bool is_terminated;
+
+        struct FinishAction finish;
 };
 
@@ -57 +79 @@
 void ?{}(processor * this, cluster * cltr);
 void ^?{}(processor * this);
-
-//-----------------------------------------------------------------------------
-// Locks
-
-void ?{}(simple_lock * this);
-void ^?{}(simple_lock * this);
-
-void lock( simple_lock * );
-void unlock( simple_lock * );
 
 #endif //KERNEL_H