Changeset d923fca for tests/concurrency/pthread/pthread_demo_create_join.cfa

Timestamp:

Feb 18, 2025, 12:54:23 PM (6 weeks ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

8705a11

Parents:

3e5fea2

Message:

Clean-up the warnings of the concurrency tests. A lot of little test level fixes, the most interesting repeated one is some formally redundent fallthough statements. pthread_attr_test had to be rewritten because of library restrictions. Changed some types so they would always be pointer sized. There was a library change, there was a function that could not be implemented; I trust that it is included for a reason so I just put it in a comment. There is a change to the compiler, wait-until now uses goto. The labelled breaks were code generated as unlabelled breaks and although it worked out slipped through some checks. Finally, there is one warning that I cannot solve at this time so tests that produce it have been put in their own lax group.

File:

• tests/concurrency/pthread/pthread_demo_create_join.cfa (modified) (3 diffs)

tests/concurrency/pthread/pthread_demo_create_join.cfa ¶

@@ -3 +3 @@
 /* test pthread create/join/exit */
 
-int arr[20];
+size_t arr[20];
 
 void* fetch(void* idx){
-    int res = arr[(uint64_t)idx];
+    size_t res = arr[(size_t)idx];
     pthread_exit((void*)res);
     sout | "it should not be here";
@@ -19 +19 @@
 }
 
-int main(int argc, char const *argv[])
+int main()
 {
     pthread_t threads[20];
     arr_init();
     int status;
-    for (int i = 0; i < 20; i++){
+    for (size_t i = 0; i < 20; i++){
         status = pthread_create(&threads[i], NULL, fetch, (void*)i);
         if (status != 0) exit(1);
@@ -30 +30 @@
     int res = 0;
     for (int i = 0; i < 20; i++){
-        void* _res = NULL;
-        status = pthread_join(threads[i], &_res);
+        void* res_i = NULL;
+        status = pthread_join(threads[i], &res_i);
         if (status != 0) exit(2);
-        if (((uint64_t)_res) != i) exit(3);
-        res += (uint64_t)_res;
+        if (((size_t)res_i) != i) exit(3);
+        res += (size_t)res_i;
     }
     sout | "final res is" | res;