Changeset d923fca for tests/concurrency/lockfree_stack.cfa

Timestamp:

Feb 18, 2025, 12:54:23 PM (6 weeks ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

8705a11

Parents:

3e5fea2

Message:

Clean-up the warnings of the concurrency tests. A lot of little test level fixes, the most interesting repeated one is some formally redundent fallthough statements. pthread_attr_test had to be rewritten because of library restrictions. Changed some types so they would always be pointer sized. There was a library change, there was a function that could not be implemented; I trust that it is included for a reason so I just put it in a comment. There is a change to the compiler, wait-until now uses goto. The labelled breaks were code generated as unlabelled breaks and although it worked out slipped through some checks. Finally, there is one warning that I cannot solve at this time so tests that produce it have been put in their own lax group.

File:

• tests/concurrency/lockfree_stack.cfa (modified) (5 diffs)

tests/concurrency/lockfree_stack.cfa ¶

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// lockfree_stack.cfa -- 
+// lockfree_stack.cfa --
 //
 // Author           : Peter A. Buhr
@@ -12 +12 @@
 // Last Modified On : Fri Jun  9 14:01:07 2023
 // Update Count     : 68
-// 
+//
 
 #include <thread.hfa>
@@ -42 +42 @@
         n.next = stack;                                                                         // atomic assignment unnecessary
         for () {                                                                                        // busy wait
-                Link temp{ &n, n.next.count + 1 };
+                Link temp{ { &n, n.next.count + 1 } };
                 if ( CASV( s.stack.atom, n.next.atom, temp.atom ) ) break; // attempt to update top node
         }
@@ -51 +51 @@
         for () {                                                                                        // busy wait
                 if ( t.top == NULL ) return NULL;                               // empty stack ?
-                Link temp{ t.top->next.top, t.count };
+                Link temp{ { t.top->next.top, t.count } };
                 if ( CASV( stack.atom, t.atom, temp.atom ) ) return t.top; // attempt to update top node
         }
@@ -62 +62 @@
 
 thread Worker {};
-void main( Worker & w ) {
+void main( Worker & ) {
         for ( i; Times ) {
                 Node & n = *pop( stack );                                               // pop any node