Changeset d923fca for tests/Makefile.am

Timestamp:

Feb 18, 2025, 12:54:23 PM (6 weeks ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

8705a11

Parents:

3e5fea2

Message:

Clean-up the warnings of the concurrency tests. A lot of little test level fixes, the most interesting repeated one is some formally redundent fallthough statements. pthread_attr_test had to be rewritten because of library restrictions. Changed some types so they would always be pointer sized. There was a library change, there was a function that could not be implemented; I trust that it is included for a reason so I just put it in a comment. There is a change to the compiler, wait-until now uses goto. The labelled breaks were code generated as unlabelled breaks and although it worked out slipped through some checks. Finally, there is one warning that I cannot solve at this time so tests that produce it have been put in their own lax group.

File:

• tests/Makefile.am (modified) (3 diffs)

tests/Makefile.am ¶

@@ -52 +52 @@
 WFLAGS_OPT_LAX = \
         ${WFLAGS_OPT_LAX_EXPECT_WARN} \
+        ${WFLAGS_OPT_LAX_WAITING_ON_303} \
         ${WFLAGS_OPT_LAX_TO_INVESTIGATE}
 
@@ -60 +61 @@
         warnings/self-assignment
 
-# Tests that need investigation from the CFA team about why they require lax wflags.  Goal is to eliminate this list.
-WFLAGS_OPT_LAX_TO_INVESTIGATE = \
+# These are failing because of trac #303; it is not likely to be fixed soon.
+# It only shows up on some configurations and machines.
+WFLAGS_OPT_LAX_WAITING_ON_303 = \
         concurrency/actors/dynamic \
         concurrency/actors/executor \
@@ -70 +72 @@
         concurrency/actors/poison \
         concurrency/actors/static \
-        concurrency/actors/types \
-        concurrency/channels/churn \
-        concurrency/channels/contend \
-        concurrency/channels/daisy_chain \
-        concurrency/channels/hot_potato \
-        concurrency/channels/pub_sub \
-        concurrency/futures/multi \
-        concurrency/futures/select_future \
-        concurrency/futures/typed \
-        concurrency/lockfree_stack \
-        concurrency/pthread/bounded_buffer \
-        concurrency/pthread/pthread_attr_test \
-        concurrency/pthread/pthread_demo_create_join \
-        concurrency/pthread/pthread_demo_lock \
-        concurrency/pthread/pthread_key_test \
-        concurrency/waituntil/all_types \
-        concurrency/waituntil/basic_else \
-        concurrency/waituntil/channel_close \
-        concurrency/waituntil/channels \
-        concurrency/waituntil/futures \
-        concurrency/waituntil/locks \
-        concurrency/waituntil/repeat_close \
-        concurrency/waituntil/timeout \
+        concurrency/actors/types
+
+# Tests that need investigation from the CFA team about why they require lax wflags.  Goal is to eliminate this list.
+WFLAGS_OPT_LAX_TO_INVESTIGATE = \
         exceptions/cardgame \
         exceptions/defaults \