Changeset d923fca for src/Concurrency/Waituntil.cpp

Timestamp:

Feb 18, 2025, 12:54:23 PM (6 weeks ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

8705a11

Parents:

3e5fea2

Message:

Clean-up the warnings of the concurrency tests. A lot of little test level fixes, the most interesting repeated one is some formally redundent fallthough statements. pthread_attr_test had to be rewritten because of library restrictions. Changed some types so they would always be pointer sized. There was a library change, there was a function that could not be implemented; I trust that it is included for a reason so I just put it in a comment. There is a change to the compiler, wait-until now uses goto. The labelled breaks were code generated as unlabelled breaks and although it worked out slipped through some checks. Finally, there is one warning that I cannot solve at this time so tests that produce it have been put in their own lax group.

File:

• src/Concurrency/Waituntil.cpp (modified) (3 diffs)

src/Concurrency/Waituntil.cpp ¶

@@ -720 +720 @@
                                                 )
                                             ),
-                                            new BranchStmt( cLoc, BranchStmt::Kind::Break, Label( cLoc, switchLabel ) )
+                                            new BranchStmt( cLoc, BranchStmt::Goto, Label( cLoc, switchLabel ) )
                                         }
                                     )
@@ -733 +733 @@
                         new NameExpr( loc, idxName ),
                         std::move( switchCases ),
+                        {}
+                )
+        );
+
+        ifBody->push_back(
+                new NullStmt( loc,
                         { Label( loc, switchLabel ) }
                 )
@@ -790 +796 @@
                                                 { new NameExpr( loc, clauseData.at(0)->statusName ) }
                                             ),
-                                            new BranchStmt( loc, BranchStmt::Kind::Break, Label( loc, forLabel ) )
+                                            new BranchStmt( loc, BranchStmt::Goto, Label( loc, forLabel ) )
                                         ),
                                         ifSwitch
                                     }
                                 ),   // body
+                                {}
+                        ),
+                        new NullStmt( loc,
                                 { Label( loc, forLabel ) }
                         )