Changeset d8938622 for src/AST

Timestamp:

May 22, 2019, 3:38:47 PM (6 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

6380f78

Parents:

37eef7a

Message:

Broken GenericSubstitution? version

Location:

src/AST

Files:

• Expr.cpp (modified) (2 diffs)
• GenericSubstitution.cpp (added)
• GenericSubstitution.hpp (added)
• Node.hpp (modified) (1 diff)
• Pass.hpp (modified) (1 diff)
• Stmt.cpp (modified) (1 diff)
• TypeSubstitution.hpp (modified) (3 diffs)
• module.mk (modified) (1 diff)
• porting.md (modified) (3 diffs)

src/AST/Expr.cpp

@@ -20 +20 @@
 #include <vector>
 
+#include "GenericSubstitution.hpp"
 #include "Stmt.hpp"
 #include "Type.hpp"
+#include "TypeSubstitution.hpp"
 #include "Common/utility.h"
 #include "Common/SemanticError.h"
@@ -157 +159 @@
         assert( aggregate->result );
 
-        assert(!"unimplemented; need TypeSubstitution, genericSubstitution");
+        // take ownership of member type
+        Type * res = result.set_and_mutate( mem->get_type() );
+        // substitute aggregate generic parameters into member type
+        genericSubsitution( aggregate->result ).apply( res );
+        // ensure lvalue and appropriate restrictions from aggregate type
+        res->set_lvalue( true );
+        res->qualifiers |= aggregate->result->qualifiers;
+        // ensure changes propegated back into result
+        result = res;
 }
 

src/AST/Node.hpp

@@ -94 +94 @@
 std::ostream& operator<< ( std::ostream& out, const Node * node );
 
+/// Call a visitor on a possibly-null node
+template<typename node_t>
+auto maybe_accept( const node_t * n, Visitor & v ) -> decltype( n->accept(v) ) {
+        return n ? n->accept( v ) : nullptr;
+}
+
 /// Base class for the smart pointer types
 /// should never really be used.

src/AST/Pass.hpp

@@ -223 +223 @@
 };
 
+/// Apply a pass to an entire translation unit
 template<typename pass_t>
 void accept_all( std::list< ast::ptr<ast::Decl> > &, ast::Pass<pass_t> & visitor );

src/AST/Stmt.cpp

@@ -22 +22 @@
 // --- CompoundStmt
 CompoundStmt::CompoundStmt( const CompoundStmt& o ) : Stmt(o), kids(o.kids) {
+#   warning unimplemented
         assert(!"implemented");
 }

src/AST/TypeSubstitution.hpp

@@ -25 +25 @@
 #include "Fwd.hpp"        // for UniqueId
 #include "ParseNode.hpp"
-#include "Type.hpp"       // for ptr<Type>
+#include "Type.hpp"       
 #include "Common/SemanticError.h"  // for SemanticError
 #include "Visitor.hpp"
@@ -165 +165 @@
         assert( input );
         Pass<Substituter> sub( *this, false );
-        input = dynamic_cast< SynTreeClass * >( input->acceptMutator( sub ) );
-        assert( input );
+        input = strict_dynamic_cast< SynTreeClass * >( input->accept( sub ) );
 ///     std::cerr << "substitution result is: ";
 ///     newType->print( std::cerr );
@@ -177 +176 @@
         assert( input );
         Pass<Substituter> sub( *this, true );
-        input = dynamic_cast< SynTreeClass * >( input->acceptMutator( sub ) );
-        assert( input );
+        input = strict_dynamic_cast< SynTreeClass * >( input->accept( sub ) );
 ///     std::cerr << "substitution result is: ";
 ///     newType->print( std::cerr );

src/AST/module.mk

@@ -21 +21 @@
         AST/DeclReplacer.cpp \
         AST/Expr.cpp \
+        AST/GenericSubstitution.cpp \
         AST/Init.cpp \
         AST/LinkageSpec.cpp \

src/AST/porting.md

@@ -38 +38 @@
 
 `N->print(std::ostream&)` is a visitor now, port these methods to `ast::Print` class
-* **TODO** write this visitor
-* **TODO** write `std::ostream& operator<< ( std::ostream& out, const Node* node )` in `Node.hpp` in terms of `ast::Print`
-* `Declaration::printShort` should also be integrated
+* **TODO** `Declaration::printShort` should also be integrated
 
 `clone` is private to `Node` now
@@ -208 +206 @@
 
 `CompoundStmt`
-* **TODO** port copy operator
-  * Needs to be an almost-shallow clone, where the declarations are cloned only if needed
-  * **TODO** port `DeclReplacer`
 * Still a `std::list` for children, rather than `std::vector`
   * allows more-efficient splicing for purposes of later code generation
@@ -229 +224 @@
   * `getAggr()` => `aggr()`
     * also now returns `const AggregateDecl *`
-* `genericSubstitution()` moved to own visitor in `AST/GenericSubstitution.hpp` **TODO** write
+* `genericSubstitution()` moved to own visitor in `AST/GenericSubstitution.hpp`
 
 `BasicType`