Changeset d7d63e5 for src

Timestamp:

Aug 6, 2018, 10:49:15 AM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, no_list, persistent-indexer, pthread-emulation, qualifiedEnum

Children:

5e44ac2

Parents:

8316a49

Message:

Handle memory leaks in cforall_demangle

File:

• src/SymTab/Demangle.cc (modified) (4 diffs)

src/SymTab/Demangle.cc

@@ -430 +430 @@
                                 if (done()) return nullptr;
                                 FunctionType * ftype = new FunctionType( tq, false );
+                                std::unique_ptr<Type> manager(ftype);
                                 Type * retVal = parseType();
                                 if (! retVal) return nullptr;
@@ -437 +438 @@
                                 while (! done()) {
                                         PRINT( std::cerr << "got ch: " << cur() << std::endl; )
-                                        if (cur() == '_') return ftype;
+                                        if (cur() == '_') return manager.release();
                                         Type * param = parseType();
                                         if (! param) return nullptr;
@@ -452 +453 @@
                                 if (! extractNumber(ncomponents)) return nullptr;
                                 for (size_t i = 0; i < ncomponents; ++i) {
+                                        // TODO: delete all on return
                                         if (done()) return nullptr;
                                         PRINT( std::cerr << "got ch: " << cur() << std::endl; )
@@ -515 +517 @@
                                 Type * type = nullptr;
                                 if (! view.parse(name, type)) return mangleName;
+                                std::unique_ptr<Type> manager(type);
                                 return genDemangleType(type, name);
                         }