Changeset cf34e82 for src/GenPoly/InstantiateGenericNew.cpp

Timestamp:

Oct 3, 2023, 5:31:59 PM (10 months ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

master

Children:

2261bcc, 3cbe320

Parents:

11ab0b4a (diff), 1ee0a4da (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

File:

• src/GenPoly/InstantiateGenericNew.cpp (modified) (3 diffs)

src/GenPoly/InstantiateGenericNew.cpp

@@ -335 +335 @@
 ast::Expr const * FixDtypeStatic::postvisit( ast::MemberExpr const * expr ) {
         ast::ptr<ast::Type> const & type = expr->aggregate->result;
-        if ( !isGenericType( type ) ) {
-                return expr;
-        } else if ( auto inst = type.as<ast::StructInstType>() ) {
-                return fixMemberExpr( inst, expr );
+        if ( auto inst = type.as<ast::StructInstType>() ) {
+                if ( !inst->params.empty() ) return fixMemberExpr( inst, expr );
         } else if ( auto inst = type.as<ast::UnionInstType>() ) {
-                return fixMemberExpr( inst, expr );
+                if ( !inst->params.empty() ) return fixMemberExpr( inst, expr );
         }
         return expr;
@@ -451 +449 @@
         ast::Expr const * postvisit( ast::MemberExpr const * expr );
         ast::Expr const * postvisit( ast::Expr const * expr );
-        void previsit( ast::ParseNode const * node );
-
+        ast::Designation const * postvisit( ast::Designation const * );
+
+        void previsit( ast::ParseNode const * node ) {
+                GuardValue( location ) = &node->location;
+        }
         void previsit( ast::FunctionType const * ) {
                 GuardValue( inFunctionType ) = true;
@@ -628 +629 @@
 }
 
-void GenericInstantiator::previsit( ast::ParseNode const * node ) {
-        GuardValue( location ) = &node->location;
+// This attempts to figure out what the final name of the field will be.
+// Pretty printing can cause this to become incorrect.
+std::string getPrintName( ast::DeclWithType const * decl ) {
+        return ( decl->linkage.is_mangled )
+                ? decl->scopedMangleName() : decl->name;
+}
+
+ast::Designation const * GenericInstantiator::postvisit(
+                ast::Designation const * designation ) {
+        // Disconnect designator names from their fields.
+        // It is now incorrect to point at the generic definition where the used
+        // type now is replaced with a concrete instance. Ideally, new variable
+        // expressions would point at fields in the concrete instances, but that
+        // is work and that information should not be needed this late in
+        // compilation.
+
+        // Modify all designations, even if not needed.
+        auto mutNode = mutate( designation );
+        for ( ast::ptr<ast::Expr> & designator : mutNode->designators ) {
+                if ( auto var = designator.as<ast::VariableExpr>() ) {
+                        designator = new ast::NameExpr(
+                                var->location, getPrintName( var->var ) );
+                }
+        }
+        return mutNode;
 }