Changeset c457dc41 for libcfa/src/concurrency/alarm.cfa

Timestamp:

May 14, 2021, 5:23:49 PM (3 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

353aaba

Parents:

e2f601f

Message:

Fix sequential handling of timers

File:

• libcfa/src/concurrency/alarm.cfa (modified) (5 diffs)

libcfa/src/concurrency/alarm.cfa

@@ -38 +38 @@
 
 void __kernel_set_timer( Duration alarm ) {
-        verifyf(alarm >= 1`us || alarm == 0, "Setting timer to < 1us (%jins)", alarm`ns);
-        setitimer( ITIMER_REAL, &(itimerval){ alarm }, 0p );
+        alarm = max(alarm, 1`us);
+        itimerval otv @= { 0 };
+        getitimer( ITIMER_REAL, &otv );
+        Duration od = { otv.it_value };
+        if(od == 0 || od > alarm) {
+                setitimer( ITIMER_REAL, &(itimerval){ alarm }, 0p );
+        }
 }
 
@@ -46 +51 @@
 //=============================================================================================
 
-void ?{}( alarm_node_t & this, $thread * thrd, Time alarm, Duration period) with( this ) {
+void ?{}( alarm_node_t & this, $thread * thrd, Duration alarm, Duration period) with( this ) {
+        this.initial = alarm;
+        this.period  = period;
         this.thrd = thrd;
-        this.alarm = alarm;
-        this.period = period;
         set = false;
         type = User;
 }
 
-void ?{}( alarm_node_t & this, processor * proc, Time alarm, Duration period ) with( this ) {
+void ?{}( alarm_node_t & this, processor * proc, Duration alarm, Duration period ) with( this ) {
+        this.initial = alarm;
+        this.period  = period;
         this.proc = proc;
-        this.alarm = alarm;
-        this.period = period;
         set = false;
         type = Kernel;
 }
-void ?{}( alarm_node_t & this, Alarm_Callback callback, Time alarm, Duration period ) with( this ) {
-        this.alarm = alarm;
-        this.period = period;
+void ?{}( alarm_node_t & this, Alarm_Callback callback, Duration alarm, Duration period ) with( this ) {
+        this.initial = alarm;
+        this.period  = period;
         this.callback = callback;
         set = false;
@@ -77 +82 @@
 void insert( alarm_list_t * this, alarm_node_t * n ) {
         alarm_node_t * it = & (*this)`first;
-        while( it && (n->alarm > it->alarm) ) {
+        while( it && (n->timeval > it->timeval) ) {
                 it = & (*it)`next;
         }
@@ -105 +110 @@
         lock( event_kernel->lock __cfaabi_dbg_ctx2 );
         {
-                verify( validate( alarms ) );
-                bool first = ! & alarms`first;
+                Time curr = __kernel_get_time();
+                this->timeval = curr + this->initial;
 
-                __cfadbg_print_safe( preemption, " KERNEL: alarm inserting %p (%lu).\n", this, this->alarm.tn );
+                /* paranoid */ verify( validate( alarms ) );
+
+                __cfadbg_print_safe( preemption, " KERNEL: alarm inserting %p (%lu -> %lu).\n", this, curr.tn, this->timeval.tn );
                 insert( &alarms, this );
-                if( first ) {
-                        __kernel_set_timer( alarms`first.alarm - __kernel_get_time() );
-                }
+                __kernel_set_timer( this->initial );
         }
         unlock( event_kernel->lock );
@@ -136 +141 @@
 
 void sleep( Duration duration ) {
-        alarm_node_t node = { active_thread(), __kernel_get_time() + duration, 0`s };
+        alarm_node_t node = { active_thread(), duration, 0`s };
 
         register_self( &node );