Changeset c3a2007 for src/SynTree/CommaExpr.cc

Timestamp:

Oct 28, 2019, 4:28:37 PM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

8364209

Parents:

c921712 (diff), 9bdb8b7 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

File:

• src/SynTree/CommaExpr.cc (modified) (2 diffs)

src/SynTree/CommaExpr.cc

@@ -23 +23 @@
 CommaExpr::CommaExpr( Expression *arg1, Expression *arg2 )
                 : Expression(), arg1( arg1 ), arg2( arg2 ) {
-        // xxx - result of a comma expression is never an lvalue, so should set lvalue
-        // to false on all result types. Actually doing this causes some strange things
-        // to happen in later passes (particularly, Specialize, Lvalue, and Box). This needs to be looked into.
         set_result( maybeClone( arg2->get_result() ) );
-        // get_type->set_isLvalue( false );
 }
 
@@ -40 +36 @@
 
 bool CommaExpr::get_lvalue() const {
-        // xxx - as above, shouldn't be an lvalue but that information is used anyways.
-        return result->get_lvalue();
+        // This is wrong by C, but the current implementation uses it.
+        // (ex: Specialize, Lvalue and Box)
+        return arg2->get_lvalue();
 }