Changeset c13e8dc8 for src/SymTab

Timestamp:

Dec 5, 2017, 2:35:03 PM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

f9feab8

Parents:

9c35431 (diff), 65197c2 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' into cleanup-dtors

Location:

src/SymTab

Files:

• AddVisit.h (modified) (2 diffs)
• Autogen.cc (modified) (6 diffs)
• Autogen.h (modified) (2 diffs)
• ImplementationType.cc (deleted)
• ImplementationType.h (deleted)
• Indexer.cc (modified) (15 diffs)
• Indexer.h (modified) (4 diffs)
• TypeEquality.cc (deleted)
• TypeEquality.h (deleted)
• Validate.cc (modified) (3 diffs)
• module.mk (modified) (1 diff)

src/SymTab/AddVisit.h

@@ -24 +24 @@
                         // add any new declarations after the previous statement
                         for ( std::list< Declaration* >::iterator decl = visitor.declsToAddAfter.begin(); decl != visitor.declsToAddAfter.end(); ++decl ) {
-                                DeclStmt *declStmt = new DeclStmt( noLabels, *decl );
+                                DeclStmt *declStmt = new DeclStmt( *decl );
                                 stmts.insert( stmt, declStmt );
                         }
@@ -36 +36 @@
                         // add any new declarations before the statement
                         for ( std::list< Declaration* >::iterator decl = visitor.declsToAdd.begin(); decl != visitor.declsToAdd.end(); ++decl ) {
-                                DeclStmt *declStmt = new DeclStmt( noLabels, *decl );
+                                DeclStmt *declStmt = new DeclStmt( *decl );
                                 stmts.insert( stmt, declStmt );
                         }

src/SymTab/Autogen.cc

@@ -267 +267 @@
                 Type::StorageClasses scs = functionNesting > 0 ? Type::StorageClasses() : Type::StorageClasses( Type::Static );
                 LinkageSpec::Spec spec = isIntrinsic ? LinkageSpec::Intrinsic : LinkageSpec::AutoGen;
-                FunctionDecl * decl = new FunctionDecl( fname, scs, spec, ftype, new CompoundStmt( noLabels ),
+                FunctionDecl * decl = new FunctionDecl( fname, scs, spec, ftype, new CompoundStmt(),
                                                                                                 std::list< Attribute * >(), Type::FuncSpecifiers( Type::Inline ) );
                 decl->fixUniqueId();
@@ -302 +302 @@
                                 assert( assignType->returnVals.size() == 1 );
                                 ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( assignType->parameters.front() );
-                                dcl->statements->push_back( new ReturnStmt( noLabels, new VariableExpr( dstParam ) ) );
+                                dcl->statements->push_back( new ReturnStmt( new VariableExpr( dstParam ) ) );
                         }
                         resolve( dcl );
@@ -471 +471 @@
                 copy->args.push_back( new AddressExpr( new VariableExpr( srcParam ) ) );
                 copy->args.push_back( new SizeofExpr( srcParam->get_type()->clone() ) );
-                *out++ = new ExprStmt( noLabels, copy );
+                *out++ = new ExprStmt( copy );
         }
 
@@ -547 +547 @@
                         callExpr->get_args().push_back( new VariableExpr( dstParam ) );
                         callExpr->get_args().push_back( new VariableExpr( srcParam ) );
-                        funcDecl->statements->push_back( new ExprStmt( noLabels, callExpr ) );
+                        funcDecl->statements->push_back( new ExprStmt( callExpr ) );
                 } else {
                         // default ctor/dtor body is empty - add unused attribute to parameter to silence warnings
@@ -572 +572 @@
                 expr->args.push_back( new CastExpr( new VariableExpr( dst ), new ReferenceType( Type::Qualifiers(), typeDecl->base->clone() ) ) );
                 if ( src ) expr->args.push_back( new CastExpr( new VariableExpr( src ), typeDecl->base->clone() ) );
-                dcl->statements->kids.push_back( new ExprStmt( noLabels, expr ) );
+                dcl->statements->kids.push_back( new ExprStmt( expr ) );
         };
 
@@ -667 +667 @@
                         untyped->get_args().push_back( new VariableExpr( ftype->get_parameters().back() ) );
                 }
-                function->get_statements()->get_kids().push_back( new ExprStmt( noLabels, untyped ) );
-                function->get_statements()->get_kids().push_back( new ReturnStmt( noLabels, UntypedExpr::createDeref( new VariableExpr( ftype->get_parameters().front() ) ) ) );
+                function->get_statements()->get_kids().push_back( new ExprStmt( untyped ) );
+                function->get_statements()->get_kids().push_back( new ReturnStmt( UntypedExpr::createDeref( new VariableExpr( ftype->get_parameters().front() ) ) ) );
         }
 

src/SymTab/Autogen.h

@@ -107 +107 @@
                 fExpr->args.splice( fExpr->args.end(), args );
 
-                *out++ = new ExprStmt( noLabels, fExpr );
+                *out++ = new ExprStmt( fExpr );
 
                 srcParam.clearArrayIndices();
@@ -165 +165 @@
 
                 // for stmt's body, eventually containing call
-                CompoundStmt * body = new CompoundStmt( noLabels );
+                CompoundStmt * body = new CompoundStmt();
                 Statement * listInit = genCall( srcParam, dstParam, fname, back_inserter( body->kids ), array->base, addCast, forward );
 
                 // block containing for stmt and index variable
                 std::list<Statement *> initList;
-                CompoundStmt * block = new CompoundStmt( noLabels );
-                block->push_back( new DeclStmt( noLabels, index ) );
+                CompoundStmt * block = new CompoundStmt();
+                block->push_back( new DeclStmt( index ) );
                 if ( listInit ) block->get_kids().push_back( listInit );
-                block->push_back( new ForStmt( noLabels, initList, cond, inc, body ) );
+                block->push_back( new ForStmt( initList, cond, inc, body ) );
 
                 *out++ = block;

src/SymTab/Indexer.cc

@@ -40 +40 @@
 
 namespace SymTab {
-        typedef std::unordered_map< std::string, DeclarationWithType* > MangleTable;
+        std::ostream & operator<<( std::ostream & out, const Indexer::IdData & data ) {
+                return out << "(" << data.id << "," << data.baseExpr << ")";
+        }
+
+        typedef std::unordered_map< std::string, Indexer::IdData > MangleTable;
         typedef std::unordered_map< std::string, MangleTable > IdTable;
         typedef std::unordered_map< std::string, NamedTypeDecl* > TypeTable;
@@ -97 +101 @@
         }
 
-        void Indexer::removeSpecialOverrides( const std::string &id, std::list< DeclarationWithType * > & out ) const {
+        void Indexer::removeSpecialOverrides( const std::string &id, std::list< IdData > & out ) const {
                 // only need to perform this step for constructors, destructors, and assignment functions
                 if ( ! CodeGen::isCtorDtorAssign( id ) ) return;
@@ -104 +108 @@
                 struct ValueType {
                         struct DeclBall {
-                                FunctionDecl * decl;
+                                IdData decl;
                                 bool isUserDefinedFunc; // properties for this particular decl
                                 bool isDefaultCtor;
@@ -120 +124 @@
                         // another FunctionDecl for the current type was found - determine
                         // if it has special properties and update data structure accordingly
-                        ValueType & operator+=( FunctionDecl * function ) {
+                        ValueType & operator+=( IdData data ) {
+                                DeclarationWithType * function = data.id;
                                 bool isUserDefinedFunc = ! LinkageSpec::isOverridable( function->get_linkage() );
                                 bool isDefaultCtor = InitTweak::isDefaultConstructor( function );
                                 bool isDtor = InitTweak::isDestructor( function );
                                 bool isCopyFunc = InitTweak::isCopyFunction( function, function->get_name() );
-                                decls.push_back( DeclBall{ function, isUserDefinedFunc, isDefaultCtor, isDtor, isCopyFunc } );
+                                decls.push_back( DeclBall{ data, isUserDefinedFunc, isDefaultCtor, isDtor, isCopyFunc } );
                                 existsUserDefinedFunc = existsUserDefinedFunc || isUserDefinedFunc;
                                 existsUserDefinedCtor = existsUserDefinedCtor || (isUserDefinedFunc && CodeGen::isConstructor( function->get_name() ) );
@@ -135 +140 @@
                 }; // ValueType
 
-                std::list< DeclarationWithType * > copy;
+                std::list< IdData > copy;
                 copy.splice( copy.end(), out );
 
                 // organize discovered declarations by type
                 std::unordered_map< std::string, ValueType > funcMap;
-                for ( DeclarationWithType * decl : copy ) {
-                        if ( FunctionDecl * function = dynamic_cast< FunctionDecl * >( decl ) ) {
+                for ( auto decl : copy ) {
+                        if ( FunctionDecl * function = dynamic_cast< FunctionDecl * >( decl.id ) ) {
                                 std::list< DeclarationWithType * > & params = function->get_functionType()->get_parameters();
                                 assert( ! params.empty() );
@@ -147 +152 @@
                                 Type * base = InitTweak::getPointerBase( params.front()->get_type() );
                                 assert( base );
-                                funcMap[ Mangler::mangle( base ) ] += function;
+                                funcMap[ Mangler::mangle( base ) ] += decl;
                         } else {
                                 out.push_back( decl );
@@ -164 +169 @@
                                 bool noUserDefinedFunc = ! val.existsUserDefinedFunc;
                                 bool isUserDefinedFunc = ball.isUserDefinedFunc;
-                                bool isAcceptableDefaultCtor = (! val.existsUserDefinedCtor || (! val.existsUserDefinedDefaultCtor && ball.decl->get_linkage() == LinkageSpec::Intrinsic)) && ball.isDefaultCtor; // allow default constructors only when no user-defined constructors exist, except in the case of intrinsics, which require exact overrides
+                                bool isAcceptableDefaultCtor = (! val.existsUserDefinedCtor || (! val.existsUserDefinedDefaultCtor && ball.decl.id->get_linkage() == LinkageSpec::Intrinsic)) && ball.isDefaultCtor; // allow default constructors only when no user-defined constructors exist, except in the case of intrinsics, which require exact overrides
                                 bool isAcceptableCopyFunc = ! val.existsUserDefinedCopyFunc && ball.isCopyFunc; // handles copy ctor and assignment operator
                                 bool isAcceptableDtor = ! val.existsUserDefinedDtor && ball.isDtor;
@@ -219 +224 @@
         }
 
-        void Indexer::lookupId( const std::string &id, std::list< DeclarationWithType* > &out ) const {
+        void Indexer::lookupId( const std::string &id, std::list< IdData > &out ) const {
                 std::unordered_set< std::string > foundMangleNames;
 
@@ -289 +294 @@
                         const MangleTable &mangleTable = decls->second;
                         MangleTable::const_iterator decl = mangleTable.find( mangleName );
-                        if ( decl != mangleTable.end() ) return decl->second;
+                        if ( decl != mangleTable.end() ) return decl->second.id;
                 }
 
@@ -304 +309 @@
                         for ( MangleTable::const_iterator decl = mangleTable.begin(); decl != mangleTable.end(); ++decl ) {
                                 // check for C decls with the same name, skipping those with a compatible type (by mangleName)
-                                if ( ! LinkageSpec::isMangled( decl->second->get_linkage() ) && decl->first != mangleName ) return true;
+                                if ( ! LinkageSpec::isMangled( decl->second.id->get_linkage() ) && decl->first != mangleName ) return true;
                         }
                 }
@@ -321 +326 @@
                                 // check for C decls with the same name, skipping
                                 // those with an incompatible type (by mangleName)
-                                if ( ! LinkageSpec::isMangled( decl->second->get_linkage() ) && decl->first == mangleName ) return true;
+                                if ( ! LinkageSpec::isMangled( decl->second.id->get_linkage() ) && decl->first == mangleName ) return true;
                         }
                 }
@@ -403 +408 @@
         }
 
-        void Indexer::addId( DeclarationWithType *decl ) {
+        void Indexer::addId( DeclarationWithType *decl, Expression * baseExpr ) {
                 debugPrint( "Adding Id " << decl->name << std::endl );
                 makeWritable();
@@ -439 +444 @@
 
                 // add to indexer
-                tables->idTable[ name ][ mangleName ] = decl;
+                tables->idTable[ name ][ mangleName ] = { decl, baseExpr };
                 ++tables->size;
         }
@@ -563 +568 @@
                         if ( ! addedDeclConflicts( existing->second, decl ) ) {
                                 existing->second = decl;
+                        }
+                }
+        }
+
+        void Indexer::addWith( WithStmt * stmt ) {
+                for ( Expression * expr : stmt->exprs ) {
+                        if ( expr->result ) {
+                                AggregateDecl * aggr = expr->result->stripReferences()->getAggr();
+                                assertf( aggr, "WithStmt expr has non-aggregate type: %s", toString( expr->result ).c_str() );
+
+                                for ( Declaration * decl : aggr->members ) {
+                                        if ( DeclarationWithType * dwt = dynamic_cast< DeclarationWithType * >( decl ) ) {
+                                                addId( dwt, expr );
+                                        }
+                                }
                         }
                 }
@@ -645 +665 @@
 
         }
+
+        Expression * Indexer::IdData::combine() const {
+                if ( baseExpr ) {
+                        Expression * base = baseExpr->clone();
+                        ResolvExpr::referenceToRvalueConversion( base );
+                        Expression * ret = new MemberExpr( id, base );
+                        // xxx - this introduces hidden environments, for now remove them.
+                        // std::swap( base->env, ret->env );
+                        delete base->env;
+                        base->env = nullptr;
+                        return ret;
+                } else {
+                        return new VariableExpr( id );
+                }
+        }
 } // namespace SymTab
 

src/SymTab/Indexer.h

@@ -39 +39 @@
                 void leaveScope();
 
+                struct IdData {
+                        DeclarationWithType * id;
+                        Expression * baseExpr; // WithExpr
+
+                        Expression * combine() const;
+                };
+
                 /// Gets all declarations with the given ID
-                void lookupId( const std::string &id, std::list< DeclarationWithType* > &out ) const;
+                void lookupId( const std::string &id, std::list< IdData > &out ) const;
                 /// Gets the top-most type declaration with the given ID
                 NamedTypeDecl *lookupType( const std::string &id ) const;
@@ -67 +74 @@
                 TraitDecl *lookupTraitAtScope( const std::string &id, unsigned long scope ) const;
 
-                void addId( DeclarationWithType *decl );
+                void addId( DeclarationWithType *decl, Expression * baseExpr = nullptr );
                 void addType( NamedTypeDecl *decl );
                 void addStruct( const std::string &id );
@@ -75 +82 @@
                 void addUnion( UnionDecl *decl );
                 void addTrait( TraitDecl *decl );
+
+                /// adds all of the IDs from WithStmt exprs
+                void addWith( WithStmt * );
 
                 /// convenience function for adding a list of Ids to the indexer
@@ -100 +110 @@
                 // so that they will not be selected
                 // void removeSpecialOverrides( FunctionDecl *decl );
-                void removeSpecialOverrides( const std::string &id, std::list< DeclarationWithType * > & out ) const;
+                void removeSpecialOverrides( const std::string &id, std::list< IdData > & out ) const;
 
                 /// Ensures that tables variable is writable (i.e. allocated, uniquely owned by this Indexer, and at the current scope)

src/SymTab/Validate.cc

@@ -81 +81 @@
 
 namespace SymTab {
-        class HoistStruct final : public Visitor {
-                template< typename Visitor >
-                friend void acceptAndAdd( std::list< Declaration * > &translationUnit, Visitor &visitor );
-            template< typename Visitor >
-            friend void addVisitStatementList( std::list< Statement* > &stmts, Visitor &visitor );
-          public:
+        struct HoistStruct final : public WithDeclsToAdd, public WithGuards {
                 /// Flattens nested struct types
                 static void hoistStruct( std::list< Declaration * > &translationUnit );
 
-                std::list< Declaration * > &get_declsToAdd() { return declsToAdd; }
-
-                virtual void visit( EnumInstType *enumInstType );
-                virtual void visit( StructInstType *structInstType );
-                virtual void visit( UnionInstType *unionInstType );
-                virtual void visit( StructDecl *aggregateDecl );
-                virtual void visit( UnionDecl *aggregateDecl );
-
-                virtual void visit( CompoundStmt *compoundStmt );
-                virtual void visit( SwitchStmt *switchStmt );
+                void previsit( EnumInstType * enumInstType );
+                void previsit( StructInstType * structInstType );
+                void previsit( UnionInstType * unionInstType );
+                void previsit( StructDecl * aggregateDecl );
+                void previsit( UnionDecl * aggregateDecl );
+
           private:
-                HoistStruct();
-
                 template< typename AggDecl > void handleAggregate( AggDecl *aggregateDecl );
 
-                std::list< Declaration * > declsToAdd, declsToAddAfter;
-                bool inStruct;
+                bool inStruct = false;
         };
 
@@ -305 +293 @@
 
         void HoistStruct::hoistStruct( std::list< Declaration * > &translationUnit ) {
-                HoistStruct hoister;
-                acceptAndAdd( translationUnit, hoister );
-        }
-
-        HoistStruct::HoistStruct() : inStruct( false ) {
+                PassVisitor<HoistStruct> hoister;
+                acceptAll( translationUnit, hoister );
         }
 
@@ -320 +305 @@
                 if ( inStruct ) {
                         // Add elements in stack order corresponding to nesting structure.
-                        declsToAdd.push_front( aggregateDecl );
-                        Visitor::visit( aggregateDecl );
+                        declsToAddBefore.push_front( aggregateDecl );
                 } else {
+                        GuardValue( inStruct );
                         inStruct = true;
-                        Visitor::visit( aggregateDecl );
-                        inStruct = false;
                 } // if
                 // Always remove the hoisted aggregate from the inner structure.
-                filter( aggregateDecl->get_members(), isStructOrUnion, false );
-        }
-
-        void HoistStruct::visit( EnumInstType *structInstType ) {
-                if ( structInstType->get_baseEnum() ) {
-                        declsToAdd.push_front( structInstType->get_baseEnum() );
-                }
-        }
-
-        void HoistStruct::visit( StructInstType *structInstType ) {
-                if ( structInstType->get_baseStruct() ) {
-                        declsToAdd.push_front( structInstType->get_baseStruct() );
-                }
-        }
-
-        void HoistStruct::visit( UnionInstType *structInstType ) {
-                if ( structInstType->get_baseUnion() ) {
-                        declsToAdd.push_front( structInstType->get_baseUnion() );
-                }
-        }
-
-        void HoistStruct::visit( StructDecl *aggregateDecl ) {
+                GuardAction( [aggregateDecl]() { filter( aggregateDecl->members, isStructOrUnion, false ); } );
+        }
+
+        void HoistStruct::previsit( EnumInstType * inst ) {
+                if ( inst->baseEnum ) {
+                        declsToAddBefore.push_front( inst->baseEnum );
+                }
+        }
+
+        void HoistStruct::previsit( StructInstType * inst ) {
+                if ( inst->baseStruct ) {
+                        declsToAddBefore.push_front( inst->baseStruct );
+                }
+        }
+
+        void HoistStruct::previsit( UnionInstType * inst ) {
+                if ( inst->baseUnion ) {
+                        declsToAddBefore.push_front( inst->baseUnion );
+                }
+        }
+
+        void HoistStruct::previsit( StructDecl * aggregateDecl ) {
                 handleAggregate( aggregateDecl );
         }
 
-        void HoistStruct::visit( UnionDecl *aggregateDecl ) {
+        void HoistStruct::previsit( UnionDecl * aggregateDecl ) {
                 handleAggregate( aggregateDecl );
-        }
-
-        void HoistStruct::visit( CompoundStmt *compoundStmt ) {
-                addVisit( compoundStmt, *this );
-        }
-
-        void HoistStruct::visit( SwitchStmt *switchStmt ) {
-                addVisit( switchStmt, *this );
         }
 

src/SymTab/module.mk

@@ -19 +19 @@
        SymTab/Validate.cc \
        SymTab/FixFunction.cc \
-       SymTab/ImplementationType.cc \
-       SymTab/TypeEquality.cc \
        SymTab/Autogen.cc