Changeset b262cb3 for src/AST

Timestamp:

Jan 11, 2024, 8:46:37 AM (11 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

8655363

Parents:

cfbc56ec

Message:

Unified and fixed handling of parameter attributes.

File:

• src/AST/Attribute.cpp (modified) (1 diff)

src/AST/Attribute.cpp

@@ -38 +38 @@
 
 bool Attribute::isValidOnFuncParam() const {
-        // attributes such as aligned, cleanup, etc. produce GCC errors when they appear
-        // on function parameters. Maintain here a whitelist of attribute names that are
-        // allowed to appear on parameters.
+        // Attributes produce GCC errors when they appear on function
+        // parameters. This is an allow-list, switching to a forbid-list would
+        // have to at least mention:
+        // aligned
         std::string norm = normalizedName();
-        return norm == "unused" || norm == "noreturn";
+        return norm == "unused" || norm == "noreturn" || norm == "vector_size";
 }