Changeset b262cb3

Timestamp:

Jan 11, 2024, 8:46:37 AM (11 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

8655363

Parents:

cfbc56ec

Message:

Unified and fixed handling of parameter attributes.

Location:

src

Files:

• AST/Attribute.cpp (modified) (1 diff)
• Validate/Autogen.cpp (modified) (1 diff)
• Validate/ReplaceTypedef.cpp (modified) (2 diffs)

src/AST/Attribute.cpp

@@ -38 +38 @@
 
 bool Attribute::isValidOnFuncParam() const {
-        // attributes such as aligned, cleanup, etc. produce GCC errors when they appear
-        // on function parameters. Maintain here a whitelist of attribute names that are
-        // allowed to appear on parameters.
+        // Attributes produce GCC errors when they appear on function
+        // parameters. This is an allow-list, switching to a forbid-list would
+        // have to at least mention:
+        // aligned
         std::string norm = normalizedName();
-        return norm == "unused" || norm == "noreturn";
+        return norm == "unused" || norm == "noreturn" || norm == "vector_size";
 }
 

src/Validate/Autogen.cpp

@@ -440 +440 @@
 
                 auto * paramType = ast::deepCopy( member->get_type() );
-                paramType->attributes.clear();
+                erase_if( paramType->attributes, []( ast::Attribute const * attr ){
+                        return !attr->isValidOnFuncParam();
+                } );
                 ast::ObjectDecl * param = new ast::ObjectDecl(
                         getLocation(), member->name, paramType );

src/Validate/ReplaceTypedef.cpp

@@ -25 +25 @@
 
 namespace {
-
-bool isNonParameterAttribute( ast::Attribute const * attr ) {
-        static const std::vector<std::string> bad_names = {
-                "aligned", "__aligned__",
-        };
-        for ( auto name : bad_names ) {
-                if ( name == attr->name ) {
-                        return true;
-                }
-        }
-        return false;
-}
 
 struct ReplaceTypedefCore final :
@@ -101 +89 @@
                 // by typedef. GCC appears to do the same thing.
                 if ( isAtFunctionTop ) {
-                        erase_if( ret->attributes, isNonParameterAttribute );
+                        erase_if( ret->attributes, []( ast::Attribute const * attr ){
+                                return !attr->isValidOnFuncParam();
+                        } );
                 }
                 for ( const auto & attribute : type->attributes ) {