Changeset 90320ac for src/AST/Pass.proto.hpp

Timestamp:

Apr 12, 2024, 3:10:04 PM (2 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

7a36848

Parents:

b78c54f

Message:

Clean-up in the Pass template around call_accept. Removed overloads that no longer contain unique behaviour. Redundent early exits have been removed. Updated the names and removed redundent checks following up the result* type update. New constructors for the delta helper type show how the data is actually used. The differs functions are unused (that value is stored in the result* types).

File:

• src/AST/Pass.proto.hpp (modified) (3 diffs)

src/AST/Pass.proto.hpp

@@ -154 +154 @@
                 bool is_old;
 
-                delta(const Stmt * s, ssize_t i, bool old) :
-                        new_val(s), old_idx(i), is_old(old) {}
+                explicit delta(const Stmt * s) : new_val(s), old_idx(-1), is_old(false) {}
+                explicit delta(ssize_t i) : new_val(nullptr), old_idx(i), is_old(true) {}
         };
 
@@ -188 +188 @@
                 std::transform( stmts->begin(), stmts->end(), std::back_inserter( values ),
                         [](ast::ptr<ast::Stmt>& stmt) -> delta {
-                                return delta( stmt.release(), -1, false );
+                                return delta( stmt.release() );
                         });
                 stmts->clear();
@@ -201 +201 @@
                         [](ast::ptr<ast::Decl>& decl) -> delta {
                                 ast::Decl const * d = decl.release();
-                                return delta( new DeclStmt( d->location, d ), -1, false );
+                                return delta( new DeclStmt( d->location, d ) );
                         });
                 decls->clear();