Changeset 90320ac for src/AST/Pass.hpp

Timestamp:

Apr 12, 2024, 3:10:04 PM (6 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

7a36848

Parents:

b78c54f

Message:

Clean-up in the Pass template around call_accept. Removed overloads that no longer contain unique behaviour. Redundent early exits have been removed. Updated the names and removed redundent checks following up the result* type update. New constructors for the delta helper type show how the data is actually used. The differs functions are unused (that value is stored in the result* types).

File:

• src/AST/Pass.hpp (modified) (1 diff)

src/AST/Pass.hpp

@@ -252 +252 @@
 private:
 
-        __pass::result1<ast::Stmt> call_accept( const ast::Stmt * );
-        __pass::result1<ast::Expr> call_accept( const ast::Expr * );
-
-        /// This has a `type` member that is the return type for the
-        /// generic call_accept if the generic call_accept is defined.
+        /// The return type of the general call_accept function.
         template< typename node_t >
-        using generic_call_accept_result =
-                std::enable_if<
-                                !std::is_base_of<ast::Expr, node_t>::value &&
-                                !std::is_base_of<ast::Stmt, node_t>::value
-                        , __pass::result1<
-                                typename std::remove_pointer< typename std::result_of<
-                                        decltype(&node_t::accept)(node_t*, type&) >::type >::type
-                        >
+        using call_accept_result_t = __pass::result1<
+                typename std::remove_pointer< typename std::result_of<
+                        decltype(&node_t::accept)(node_t*, type&) >::type >::type
                 >;
 
         template< typename node_t >
-        auto call_accept( const node_t * node )
-                -> typename generic_call_accept_result<node_t>::type;
+        auto call_accept( const node_t * node ) -> call_accept_result_t<node_t>;
 
         // requests WithStmtsToAdd directly add to this statement, as if it is a compound.