Changeset 89be1c68 for src/ResolvExpr/Cost.h

Timestamp:

Jul 17, 2017, 2:35:52 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

7ebaa56

Parents:

b46e3bd

Message:

Remove Cost constructors, use only named members

This change makes it easier to read code involving costs, since in almost every case, only a single part of the cost tuple is relevant. Furthermore, this change makes it much simpler to add another dimension to the cost tuple, since only Cost.h needs to be updated, rather than every location using the cost constructor.

File:

• src/ResolvExpr/Cost.h (modified) (2 diffs)

src/ResolvExpr/Cost.h

@@ -21 +21 @@
 namespace ResolvExpr {
         class Cost {
-          public:
-                Cost();
+          private:
                 Cost( int unsafeCost, int polyCost, int safeCost );
 
-                void incUnsafe( int inc = 1 );
-                void incPoly( int inc = 1 );
-                void incSafe( int inc = 1 );
+          public:
+                Cost & incUnsafe( int inc = 1 );
+                Cost & incPoly( int inc = 1 );
+                Cost & incSafe( int inc = 1 );
 
                 Cost operator+( const Cost &other ) const;
@@ -50 +50 @@
         };
 
-        inline Cost::Cost() : unsafeCost( 0 ), polyCost( 0 ), safeCost( 0 ) {}
-
         inline Cost::Cost( int unsafeCost, int polyCost, int safeCost ) : unsafeCost( unsafeCost ), polyCost( polyCost ), safeCost( safeCost ) {}
 
-        inline void Cost::incUnsafe( int inc ) {
+        inline Cost & Cost::incUnsafe( int inc ) {
                 unsafeCost += inc;
+                return *this;
         }
 
-        inline void Cost::incPoly( int inc ) {
+        inline Cost & Cost::incPoly( int inc ) {
                 polyCost += inc;
+                return *this;
         }
 
-        inline void Cost::incSafe( int inc ) {
+        inline Cost & Cost::incSafe( int inc ) {
                 safeCost += inc;
+                return *this;
         }