Changeset 857b5f9 for src/ResolvExpr/CandidateFinder.cpp

Timestamp:

Jan 23, 2025, 12:09:40 PM (3 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

9e72bae3

Parents:

829821c

Message:

CountExpr? -> CountofExpr?. Actually the main fix was making countof use the same pattern as sizeof/alignof, using a typeof to combine the two cases and have one field instead of two.

File:

• src/ResolvExpr/CandidateFinder.cpp (modified) (6 diffs)

src/ResolvExpr/CandidateFinder.cpp ¶

@@ -672 +672 @@
                 void postvisit( const ast::SizeofExpr * sizeofExpr );
                 void postvisit( const ast::AlignofExpr * alignofExpr );
+                void postvisit( const ast::CountofExpr * countExpr );
                 void postvisit( const ast::AddressExpr * addressExpr );
                 void postvisit( const ast::LabelAddressExpr * labelExpr );
@@ -697 +698 @@
                 void postvisit( const ast::UntypedInitExpr * initExpr );
                 void postvisit( const ast::QualifiedNameExpr * qualifiedExpr );
-                void postvisit( const ast::CountExpr * countExpr );
 
                 void postvisit( const ast::InitExpr * ) {
@@ -941 +941 @@
                 }
         }
-        
 
         /// Adds aggregate member interpretations
@@ -1269 +1268 @@
                                         ? conversionCost( fromType, toType, cand->expr->get_lvalue(), symtab, cand->env )
                                         : castCost( fromType, toType, cand->expr->get_lvalue(), symtab, cand->env );
-                        
+
                         // Redefine enum cast
                         auto argAsEnum = fromType.as<ast::EnumInstType>();
@@ -1493 +1492 @@
         }
 
-        void Finder::postvisit( const ast::CountExpr * countExpr ) {
-                const ast::UntypedExpr * untyped = nullptr;
-                if ( countExpr->type ) {
-                        auto enumInst = countExpr->type.as<ast::EnumInstType>();
-                        if ( enumInst ) {
-                                addCandidate( ast::ConstantExpr::from_ulong(countExpr->location, enumInst->base->members.size()), tenv );
-                                return;
-                        }
-                        auto untypedFirst = ast::UntypedExpr::createCall( countExpr->location, "lowerBound", {} );
-                        auto castFirst = new ast::CastExpr( countExpr->location, untypedFirst , countExpr->type );
-                        untyped = ast::UntypedExpr::createCall(
-                                countExpr->location, "Countof", { castFirst }
-                        );
-                }
-                if (!untyped) untyped = ast::UntypedExpr::createCall(
-                                countExpr->location, "Countof", { countExpr->expr }
+        void Finder::postvisit( const ast::CountofExpr * countExpr ) {
+                if ( auto enumInst = countExpr->type.as<ast::EnumInstType>() ) {
+                        addCandidate( ast::ConstantExpr::from_ulong( countExpr->location, enumInst->base->members.size()), tenv );
+                        return;
+                }
+                auto untypedFirst = ast::UntypedExpr::createCall( countExpr->location, "lowerBound", {} );
+                auto castFirst = new ast::CastExpr( countExpr->location, untypedFirst , countExpr->type );
+                const ast::UntypedExpr * untyped = ast::UntypedExpr::createCall(
+                        countExpr->location, "Countof", { castFirst }
                 );
                 CandidateFinder finder( context, tenv );
@@ -1514 +1506 @@
                 CandidateList winners = findMinCost( finder.candidates );
                 if ( winners.size() == 0 ) {
-                        SemanticError( countExpr->expr, "Countof is not implemented for operand: " );
-                }
-                if ( winners.size() !=  1 ) {
-                        SemanticError( countExpr->expr, "Ambiguous expression in countof operand: " );
+                        SemanticError( countExpr, "Countof is not implemented: " );
+                }
+                if ( winners.size() != 1 ) {
+                        SemanticError( countExpr, "Ambiguous expression in countof: " );
                 }
                 CandidateRef & choice = winners.front();