Changeset 81e768d for tests/array.cfa

Timestamp:

Nov 28, 2024, 4:34:08 PM (3 weeks ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

master

Children:

46c4dea

Parents:

f5e37a4

Message:

Fix #276; add support for c-array parameters using dependent lengths.

Without this fix, declarations like

void f( int m, int n, float[m][n] );

would either

• generate bad C code, with unmangled variable names appearing in the function definition, or
• refuse to resolve a valid-c call of such a function.

tests/array-collections/c-dependent: add direct tests of such cases
tests/tuplearray: activate and expand cases which were blocked on #276
tests/array: activate case fm5y, which was blocked on #276; [noise] adjust source line numbers in .expect
tests/typedefRedef: expand coverage of "error, an array detail is different" cases; [noise] adjust source line numbers in .expect
tests/functions: [noise] adjust .expect to have resolved array sizes (extra casts) in the diffed code dump

The fix is:

• (ResolvExpr/ResolveTypeof?, ResolvExpr/Resolver?) Resolve the dimension expressions, where they were missed.
• (ResolvExpr/Resolver?) Prevent dimension expressions that are bound to other parameters from escaping in the function's type, to where they are out of scope. In the f example above, redact the type shown to callers from void (*)(int, int, float[m][n]) to void (*)(int, int, float[][*]).
• (ResolvExpr/Unify?) Relax the matching rules for such a type, when used at a call site, letting the patameters wildcard type match with the concrete type in scope at the caller's side.
• (Validate/ReplaceTypedef?) Apply the former, stricter matching rules to the one place where they are still needed: detecting inconsistent typedefs.

File:

• tests/array.cfa (modified) (2 diffs)

tests/array.cfa

@@ -57 +57 @@
     }
 
+    int fred2(int n,
+        int a1[],
+E1(     int a2[*],   )
+        int a4[3],
+        int T[3],
+        int a5[n]
+    ) {}
+
     int mary( int T[3],                                 // same as: int *T
               int p1[const 3],                          // same as: int const *p1
@@ -110 +118 @@
 E3( int fm4( int r, int c, int m[][] );            )    // m's immediate element type is incomplete
     int fm5x( int, int, int[*][*] );                    // same as fm1 decl
-                                                        #ifndef __cforall
-    int fm5y( int r, int c, int m[r][c] ) {}            // BUG 276: CFA chokes but should accept
-                                                        // C: same as fm1 defn
-                                                        #endif
+    int fm5y( int r, int c, int m[r][c] ) {}            // same as fm1 defn
+