Changeset 7a780ad for src/AST/Type.hpp

Timestamp:

Apr 18, 2024, 5:19:17 PM (6 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

38093ae

Parents:

60c5b6d

Message:

Moved ast::BasicType::Kind to ast::BasicKind? in its own hearder. This is more consistent with other utility enums (although we still use this as a enum class) and reduces what some files need to include. Also did a upgrade in a comment with MAX_INTEGER_TYPE, it is now part of the enum.

File:

• src/AST/Type.hpp (modified) (2 diffs)

src/AST/Type.hpp

@@ -22 +22 @@
 #include <vector>
 
+#include "BasicKind.hpp"     // for BasicKind
 #include "CVQualifiers.hpp"
 #include "Decl.hpp"          // for AggregateDecl subclasses
@@ -114 +115 @@
 class BasicType final : public Type {
 public:
-        // GENERATED START, DO NOT EDIT
-        // GENERATED BY BasicTypes-gen.cc
-        enum Kind {
-                Bool,
-                Char,
-                SignedChar,
-                UnsignedChar,
-                ShortSignedInt,
-                ShortUnsignedInt,
-                SignedInt,
-                UnsignedInt,
-                LongSignedInt,
-                LongUnsignedInt,
-                LongLongSignedInt,
-                LongLongUnsignedInt,
-                SignedInt128,
-                UnsignedInt128,
-                uFloat16,
-                uFloat16Complex,
-                uFloat32,
-                uFloat32Complex,
-                Float,
-                FloatComplex,
-                uFloat32x,
-                uFloat32xComplex,
-                uFloat64,
-                uFloat64Complex,
-                Double,
-                DoubleComplex,
-                uFloat64x,
-                uFloat64xComplex,
-                uuFloat80,
-                uFloat128,
-                uFloat128Complex,
-                uuFloat128,
-                LongDouble,
-                LongDoubleComplex,
-                uFloat128x,
-                uFloat128xComplex,
-                NUMBER_OF_BASIC_TYPES
-        } kind;
-        // GENERATED END
-
-        /// xxx -- MAX_INTEGER_TYPE should probably be in BasicTypes-gen.cc, rather than hardcoded here
-        enum { MAX_INTEGER_TYPE = UnsignedInt128 };
+        BasicKind kind;
 
         /// string names of basic types; generated to match with Kind
         static const char *typeNames[];
 
-        BasicType( Kind k, CV::Qualifiers q = {}, std::vector<ptr<Attribute>> && as = {} )
+        BasicType( BasicKind k, CV::Qualifiers q = {}, std::vector<ptr<Attribute>> && as = {} )
         : Type(q, std::move(as)), kind(k) {}
 
         /// Check if this type represents an integer type
-        bool isInteger() const { return (unsigned)kind <= (unsigned)MAX_INTEGER_TYPE; }
+        bool isInteger() const { return kind <= MAX_INTEGER_TYPE; }
 
         const Type * accept( Visitor & v ) const override { return v.visit( this ); }