Changeset 7870799 for src/ResolvExpr/PtrsAssignable.cc

Timestamp:

Jul 12, 2019, 10:49:02 AM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

ef5b828

Parents:

ee6dbae

Message:

Cast cost and conversion cost now take constant parameters.
This required supporting visiting const node.
The PassVisitor? can now visit const nodes but not when using the Indexer

File:

• src/ResolvExpr/PtrsAssignable.cc (modified) (4 diffs)

src/ResolvExpr/PtrsAssignable.cc

@@ -27 +27 @@
 namespace ResolvExpr {
         struct PtrsAssignable : public WithShortCircuiting {
-                PtrsAssignable( Type *dest, const TypeEnvironment &env );
+                PtrsAssignable( const Type * dest, const TypeEnvironment &env );
 
                 int get_result() const { return result; }
 
-                void previsit( Type * ) { visit_children = false; }
-
-                void postvisit( VoidType * voidType );
-                void postvisit( BasicType * basicType );
-                void postvisit( PointerType * pointerType );
-                void postvisit( ArrayType * arrayType );
-                void postvisit( FunctionType * functionType );
-                void postvisit( StructInstType * inst );
-                void postvisit( UnionInstType * inst );
-                void postvisit( EnumInstType * inst );
-                void postvisit( TraitInstType * inst );
-                void postvisit( TypeInstType * inst );
-                void postvisit( TupleType * tupleType );
-                void postvisit( VarArgsType * varArgsType );
-                void postvisit( ZeroType * zeroType );
-                void postvisit( OneType * oneType );
+                void previsit( const Type * ) { visit_children = false; }
+
+                void postvisit( const VoidType * voidType );
+                void postvisit( const BasicType * basicType );
+                void postvisit( const PointerType * pointerType );
+                void postvisit( const ArrayType * arrayType );
+                void postvisit( const FunctionType * functionType );
+                void postvisit( const StructInstType * inst );
+                void postvisit( const UnionInstType * inst );
+                void postvisit( const EnumInstType * inst );
+                void postvisit( const TraitInstType * inst );
+                void postvisit( const TypeInstType * inst );
+                void postvisit( const TupleType * tupleType );
+                void postvisit( const VarArgsType * varArgsType );
+                void postvisit( const ZeroType * zeroType );
+                void postvisit( const OneType * oneType );
           private:
-                Type *dest;
+                const Type * dest;
                 int result;
                 const TypeEnvironment &env;
         };
 
-        int ptrsAssignable( Type *src, Type *dest, const TypeEnvironment &env ) {
+        int ptrsAssignable( const Type *src, const Type * dest, const TypeEnvironment &env ) {
                 // std::cerr << "assignable: " << src << " | " << dest << std::endl;
-                if ( TypeInstType *destAsTypeInst = dynamic_cast< TypeInstType* >( dest ) ) {
-                        if ( const EqvClass *eqvClass = env.lookup( destAsTypeInst->get_name() ) ) {
+                if ( const TypeInstType * destAsTypeInst = dynamic_cast< const TypeInstType* >( dest ) ) {
+                        if ( const EqvClass * eqvClass = env.lookup( destAsTypeInst->get_name() ) ) {
                                 return ptrsAssignable( src, eqvClass->type, env );
                         } // if
                 } // if
-                if ( dynamic_cast< VoidType* >( dest ) ) {
+                if ( dynamic_cast< const VoidType* >( dest ) ) {
                         // void * = T * for any T is unsafe
                         // xxx - this should be safe, but that currently breaks the build
@@ -71 +71 @@
         }
 
-        PtrsAssignable::PtrsAssignable( Type *dest, const TypeEnvironment &env ) : dest( dest ), result( 0 ), env( env ) {}
-
-        void PtrsAssignable::postvisit( VoidType * ) {
+        PtrsAssignable::PtrsAssignable( const Type * dest, const TypeEnvironment &env ) : dest( dest ), result( 0 ), env( env ) {}
+
+        void PtrsAssignable::postvisit( const VoidType * ) {
                 // T * = void * is disallowed - this is a change from C, where any
                 // void * can be assigned or passed to a non-void pointer without a cast.
         }
 
-        void PtrsAssignable::postvisit( __attribute__((unused)) BasicType *basicType ) {}
-        void PtrsAssignable::postvisit( __attribute__((unused)) PointerType *pointerType ) {}
-        void PtrsAssignable::postvisit( __attribute__((unused)) ArrayType *arrayType ) {}
-        void PtrsAssignable::postvisit( __attribute__((unused)) FunctionType *functionType ) {}
-
-        void PtrsAssignable::postvisit(  __attribute__((unused)) StructInstType *inst ) {}
-        void PtrsAssignable::postvisit(  __attribute__((unused)) UnionInstType *inst ) {}
-
-        void PtrsAssignable::postvisit( EnumInstType * ) {
-                if ( dynamic_cast< BasicType* >( dest ) ) {
+        void PtrsAssignable::postvisit( const BasicType * ) {}
+        void PtrsAssignable::postvisit( const PointerType * ) {}
+        void PtrsAssignable::postvisit( const ArrayType * ) {}
+        void PtrsAssignable::postvisit( const FunctionType * ) {}
+
+        void PtrsAssignable::postvisit( const StructInstType * ) {}
+        void PtrsAssignable::postvisit( const UnionInstType * ) {}
+
+        void PtrsAssignable::postvisit( const EnumInstType * ) {
+                if ( dynamic_cast< const BasicType* >( dest ) ) {
                         // int * = E *, etc. is safe. This isn't technically correct, as each
                         // enum has one basic type that it is compatible with, an that type can
@@ -97 +97 @@
         }
 
-        void PtrsAssignable::postvisit(  __attribute__((unused)) TraitInstType *inst ) {}
-        void PtrsAssignable::postvisit( TypeInstType *inst ) {
-                if ( const EqvClass *eqvClass = env.lookup( inst->get_name() ) ) {
+        void PtrsAssignable::postvisit(  const TraitInstType * ) {}
+        void PtrsAssignable::postvisit( const TypeInstType * inst ) {
+                if ( const EqvClass * eqvClass = env.lookup( inst->name ) ) {
                         if ( eqvClass->type ) {
                                 // T * = S * for any S depends on the type bound to T
@@ -107 +107 @@
         }
 
-        void PtrsAssignable::postvisit(  __attribute__((unused)) TupleType *tupleType ) {}
-        void PtrsAssignable::postvisit(  __attribute__((unused)) VarArgsType *varArgsType ) {}
-        void PtrsAssignable::postvisit(  __attribute__((unused)) ZeroType *zeroType ) {}
-        void PtrsAssignable::postvisit(  __attribute__((unused)) OneType *oneType ) {}
+        void PtrsAssignable::postvisit( const TupleType * ) {}
+        void PtrsAssignable::postvisit( const VarArgsType * ) {}
+        void PtrsAssignable::postvisit( const ZeroType * ) {}
+        void PtrsAssignable::postvisit( const OneType * ) {}
 
 // TODO: Get rid of the `_new` suffix when the old version is removed.