Changeset 702e826 for src/Parser/ParseNode.h

Timestamp:

Mar 9, 2023, 2:37:53 PM (14 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, ast-experimental, master

Children:

fed03b3

Parents:

a29477f

Message:

Pre-translation pass on the parser. Entirely code readability improvements, no behaviour (on a larger scale) should be effected.

File:

• src/Parser/ParseNode.h (modified) (5 diffs)

src/Parser/ParseNode.h

@@ -137 +137 @@
         bool isExpressionType() const { return nullptr != dynamic_cast<T>(expr.get()); }
 
-        Expression * build() const { return const_cast<ExpressionNode *>(this)->expr.release(); }
+        Expression * build() const {
+                Expression * node = const_cast<ExpressionNode *>(this)->expr.release();
+                node->set_extension( this->get_extension() );
+                node->location = this->location;
+                return node;
+        }
 
         std::unique_ptr<Expression> expr;                                       // public because of lifetime implications
@@ -143 +148 @@
         bool extension = false;
 }; // ExpressionNode
-
-template< typename T >
-struct maybeBuild_t< Expression, T > {
-        static inline Expression * doit( const T * orig ) {
-                if ( orig ) {
-                        Expression * p = orig->build();
-                        p->set_extension( orig->get_extension() );
-                        p->location = orig->location;
-                        return p;
-                } else {
-                        return nullptr;
-                } // if
-        }
-};
 
 // Must harmonize with OperName.
@@ -199 +190 @@
 Expression * build_and_or( ExpressionNode * expr_node1, ExpressionNode * expr_node2, bool kind );
 Expression * build_unary_val( OperKinds op, ExpressionNode * expr_node );
-Expression * build_unary_ptr( OperKinds op, ExpressionNode * expr_node );
 Expression * build_binary_val( OperKinds op, ExpressionNode * expr_node1, ExpressionNode * expr_node2 );
 Expression * build_binary_ptr( OperKinds op, ExpressionNode * expr_node1, ExpressionNode * expr_node2 );
@@ -213 +203 @@
 struct DeclarationNode : public ParseNode {
         // These enumerations must harmonize with their names in DeclarationNode.cc.
-        enum BasicType { Void, Bool, Char, Int, Int128,
-                                         Float, Double, LongDouble, uuFloat80, uuFloat128,
-                                         uFloat16, uFloat32, uFloat32x, uFloat64, uFloat64x, uFloat128, uFloat128x, NoBasicType };
+        enum BasicType {
+                Void, Bool, Char, Int, Int128,
+                Float, Double, LongDouble, uuFloat80, uuFloat128,
+                uFloat16, uFloat32, uFloat32x, uFloat64, uFloat64x, uFloat128, uFloat128x,
+                NoBasicType
+        };
         static const char * basicTypeNames[];
         enum ComplexType { Complex, NoComplexType, Imaginary }; // Imaginary unsupported => parse, but make invisible and print error message
@@ -451 +444 @@
         while ( cur ) {
                 try {
-                        SynTreeType * result = dynamic_cast< SynTreeType * >( maybeBuild< typename std::pointer_traits< decltype(cur->build())>::element_type >( cur ) );
+                        SynTreeType * result = dynamic_cast< SynTreeType * >( maybeBuild( cur ) );
                         if ( result ) {
                                 result->location = cur->location;