Changeset 6d44da1 for src/SymTab/Validate.cc

Timestamp:

Sep 25, 2018, 11:35:34 AM (7 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, no_list, persistent-indexer, pthread-emulation, qualifiedEnum

Children:

c6bbcdb

Parents:

341bb80 (diff), 7428ad9 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' into shared_library

File:

• src/SymTab/Validate.cc (modified) (6 diffs)

src/SymTab/Validate.cc

@@ -62 +62 @@
 #include "ResolvExpr/typeops.h"        // for typesCompatible
 #include "ResolvExpr/Resolver.h"       // for findSingleExpression
+#include "ResolvExpr/ResolveTypeof.h"  // for resolveTypeof
 #include "SymTab/Autogen.h"            // for SizeType
 #include "SynTree/Attribute.h"         // for noAttributes, Attribute
@@ -247 +248 @@
                 void previsit( StructInstType * inst );
                 void previsit( UnionInstType * inst );
+        };
+
+        struct FixObjectType : public WithIndexer {
+                /// resolves typeof type in object, function, and type declarations
+                static void fix( std::list< Declaration * > & translationUnit );
+
+                void previsit( ObjectDecl * );
+                void previsit( FunctionDecl * );
+                void previsit( TypeDecl * );
         };
 
@@ -312 +322 @@
                 Concurrency::implementThreadStarter( translationUnit );
                 mutateAll( translationUnit, compoundliteral );
+                ResolvExpr::resolveWithExprs( translationUnit ); // must happen before FixObjectType because user-code is resolved and may contain with variables
+                FixObjectType::fix( translationUnit );
                 ArrayLength::computeLength( translationUnit );
                 acceptAll( translationUnit, finder ); // xxx - remove this pass soon
@@ -391 +403 @@
                         assert( aggr ); // TODO: need to handle forward declarations
                         for ( Declaration * member : aggr->members ) {
-                                if ( StructInstType * inst = dynamic_cast< StructInstType * >( child ) ) {
-                                        if ( StructDecl * aggr = dynamic_cast< StructDecl * >( member ) ) {
-                                                if ( aggr->name == inst->name ) {
-                                                        // TODO: is this case, and other non-TypeInstType cases, necessary?
-                                                        return new StructInstType( qualType->get_qualifiers(), aggr );
-                                                }
-                                        }
-                                } else if ( UnionInstType * inst = dynamic_cast< UnionInstType * >( child ) ) {
-                                        if ( UnionDecl * aggr = dynamic_cast< UnionDecl * > ( member ) ) {
-                                                if ( aggr->name == inst->name ) {
-                                                        return new UnionInstType( qualType->get_qualifiers(), aggr );
-                                                }
-                                        }
-                                } else if ( EnumInstType * inst = dynamic_cast< EnumInstType * >( child ) ) {
-                                        if ( EnumDecl * aggr = dynamic_cast< EnumDecl * > ( member ) ) {
-                                                if ( aggr->name == inst->name ) {
-                                                        return new EnumInstType( qualType->get_qualifiers(), aggr );
-                                                }
-                                        }
-                                } else if ( TypeInstType * inst = dynamic_cast< TypeInstType * >( child ) ) {
+                                if ( TypeInstType * inst = dynamic_cast< TypeInstType * >( child ) ) {
                                         // name on the right is a typedef
                                         if ( NamedTypeDecl * aggr = dynamic_cast< NamedTypeDecl * > ( member ) ) {
@@ -417 +410 @@
                                                         Type * ret = aggr->base->clone();
                                                         ret->get_qualifiers() = qualType->get_qualifiers();
+                                                        TypeSubstitution sub = parent->genericSubstitution();
+                                                        sub.apply(ret);
                                                         return ret;
                                                 }
@@ -1238 +1233 @@
         }
 
+        void FixObjectType::fix( std::list< Declaration * > & translationUnit ) {
+                PassVisitor<FixObjectType> fixer;
+                acceptAll( translationUnit, fixer );
+        }
+
+        void FixObjectType::previsit( ObjectDecl * objDecl ) {
+                Type *new_type = ResolvExpr::resolveTypeof( objDecl->get_type(), indexer );
+                new_type->get_qualifiers() -= Type::Lvalue; // even if typeof is lvalue, variable can never have lvalue-qualified type
+                objDecl->set_type( new_type );
+        }
+
+        void FixObjectType::previsit( FunctionDecl * funcDecl ) {
+                Type *new_type = ResolvExpr::resolveTypeof( funcDecl->type, indexer );
+                new_type->get_qualifiers() -= Type::Lvalue; // even if typeof is lvalue, variable can never have lvalue-qualified type
+                funcDecl->set_type( new_type );
+        }
+
+        void FixObjectType::previsit( TypeDecl *typeDecl ) {
+                if ( typeDecl->get_base() ) {
+                        Type *new_type = ResolvExpr::resolveTypeof( typeDecl->get_base(), indexer );
+                        new_type->get_qualifiers() -= Type::Lvalue; // even if typeof is lvalue, variable can never have lvalue-qualified type
+                        typeDecl->set_base( new_type );
+                } // if
+        }
+
         void ArrayLength::computeLength( std::list< Declaration * > & translationUnit ) {
                 PassVisitor<ArrayLength> len;