Changeset 69bafd2 for src/AST/porting.md

Timestamp:

May 15, 2019, 3:57:26 PM (5 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

3648d98

Parents:

9e1d485 (diff), be567e9 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

File:

• src/AST/porting.md (modified) (3 diffs)

src/AST/porting.md

@@ -10 +10 @@
 ## Visitors ##
 * `Visitor` and `Mutator` are combined into a single `ast::Visitor` class
-  * Base nodes now override `Node* accept( Visitor& v ) = 0` with, e.g. `Stmt* accept( Visitor& v ) override = 0`
+  * Base nodes now override `const Node * accept( Visitor & v ) const = 0` with, e.g. `const Stmt * accept( Visitor & v ) const override = 0`
 * `PassVisitor` is replaced with `ast::Pass`
 
@@ -26 +26 @@
 `clone` is private to `Node` now
 * still needs to be overriden to return appropriate type
-  * e.g. `private: virtual Stmt* clone() const override = 0;`
+  * e.g. `private: virtual Stmt * clone() const override = 0;`
+  * because friendship is not inherited, all implementations of clone need
+      /// Must be copied in ALL derived classes
+      template<typename node_t>
+      friend auto mutate(const node_t * node);
 
 All leaves of the `Node` inheritance tree are now declared `final`
@@ -170 +174 @@
 
 `AttrType`
-* did not port due to (likely) disuse
-  * best guess at use (from printing code) is deprecated handling for attributes
+* did not port due to deprecation of feature
+  * feature is `type@thing` e.g. `int@MAX`
 
 [1] https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Type-Attributes.html#Type-Attributes