Changeset 60089f4 for src/SynTree/CommaExpr.cc

Timestamp:

May 2, 2016, 3:12:59 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, gc_noraii, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

9243a501, d7903b1

Parents:

89231bc

Message:

fix printing in CommaExpr?, CompoundStmt?, ForStmt?, etc.

File:

• src/SynTree/CommaExpr.cc (modified) (3 diffs)

src/SynTree/CommaExpr.cc

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// CommaExpr.cc -- 
+// CommaExpr.cc --
 //
 // Author           : Richard C. Bilson
 // Created On       : Mon May 18 07:44:20 2015
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Mon May 18 08:09:58 2015
+// Last Modified By : Rob Schluntz
+// Last Modified On : Mon May 02 15:11:29 2016
 // Update Count     : 1
 //
@@ -20 +20 @@
 CommaExpr::CommaExpr( Expression *arg1, Expression *arg2, Expression *_aname )
                 : Expression( _aname ), arg1( arg1 ), arg2( arg2 ) {
+        // xxx - result of a comma expression is never an lvalue, so should set lvalue
+        // to false on all result types. Actually doing this causes some strange things
+        // to happen in later passes (particularly, Specialize, Lvalue, and Box). This needs to be looked into.
         cloneAll( arg2->get_results(), get_results() );
+        // for ( Type *& type : get_results() ) {
+        //      type->set_isLvalue( false );
+        // }
 }
 
@@ -33 +39 @@
 
 void CommaExpr::print( std::ostream &os, int indent ) const {
-        os << std::string( indent, ' ' ) << "Comma Expression:" << std::endl;
+        os << "Comma Expression:" << std::endl;
+        os << std::string( indent+2, ' ' );
         arg1->print( os, indent+2 );
         os << std::endl;
+        os << std::string( indent+2, ' ' );
         arg2->print( os, indent+2 );
         Expression::print( os, indent );