Changeset 5d3d281 for libcfa/src

Timestamp:

Dec 11, 2024, 7:32:08 PM (7 days ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

master

Children:

36dfdac

Parents:

e797179

Message:

Remove autogen forward declarations, which are never needed, and cause warnings about static declarations without definitions.

Intended to fix the failing test from previous commit.

Autogen forward declarations are never needed because they do not depend on each other, much less with mutual recursion.

Consequences:

• tests/.expect/(5 tests).(3 archs).txt: Accept generated code that lacks autogen forward declarations
• libcfa/src/concurrency/thread.*: Remove unused dependency on destructor from constructor (via thrd_start), by splitting trait is_thread with is_basic_thread

Location:

libcfa/src/concurrency

Files:

• thread.cfa (modified) (1 diff)
• thread.hfa (modified) (3 diffs)

libcfa/src/concurrency/thread.cfa

@@ -135 +135 @@
 //-----------------------------------------------------------------------------
 // Starting and stopping threads
-forall( T & | is_thread(T) )
+forall( T & | is_basic_thread(T) )
 void __thrd_start( T & this, void (*main_p)(T &) ) {
         thread$ * this_thrd = get_thread(this);

libcfa/src/concurrency/thread.hfa

@@ -28 +28 @@
 // thread trait
 forall( T & )
+trait is_basic_thread {
+        void main(T& this);
+        thread$ * get_thread(T& this);
+};
+forall( T & | is_basic_thread(T) )
 trait is_thread {
         void ^?{}(T& mutex this);
-        void main(T& this);
-        thread$ * get_thread(T& this);
 };
 
@@ -47 +50 @@
 
 // Inline getters for threads/coroutines/monitors
-forall( T & | is_thread(T) )
+forall( T & | is_basic_thread(T) )
 static inline coroutine$ * get_coroutine(T & this) __attribute__((const)) { return &get_thread(this)->self_cor; }
 
-forall( T & | is_thread(T) )
+forall( T & | is_basic_thread(T) )
 static inline monitor$   * get_monitor  (T & this) __attribute__((const)) { return &get_thread(this)->self_mon; }
 
@@ -60 +63 @@
 extern struct cluster * mainCluster;
 
-forall( T & | is_thread(T) )
+forall( T & | is_basic_thread(T) )
 void __thrd_start( T & this, void (*)(T &) );