Changeset 509ec82 for src/ResolvExpr/Unify.cpp

Timestamp:

Dec 1, 2024, 9:04:12 PM (10 months ago)

Author:

JiadaL <j82liang@…>

Branches:

master

Children:

eae8b37

Parents:

3e2e9b2 (diff), 1c0a3a4 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

File:

• src/ResolvExpr/Unify.cpp (modified) (1 diff)

src/ResolvExpr/Unify.cpp

@@ -292 +292 @@
                 if ( !array2 ) return;
 
-                if ( array->isVarLen != array2->isVarLen ) return;
-                if ( (array->dimension != nullptr) != (array2->dimension != nullptr) ) return;
-
-                if ( array->dimension ) {
+                // Permit cases where one side has a dimension or isVarLen,
+                // while the other side is the opposite.
+                // Acheves a wildcard-iterpretation semantics, where lack of
+                // dimension (`float a[]` or `float a[25][*]`) means
+                // "anything here is fine."
+                // Sole known case where a verbatim-match semantics is intended
+                // is typedef redefinition, for which extra checking is added
+                // in src/Validate/ReplaceTypedef.cpp.
+
+                if ( array->dimension && array2->dimension ) {
                         assert( array2->dimension );
                         // type unification calls expression unification (mutual recursion)