Changeset 4a8f150 for src/InitTweak/FixInitNew.cpp

Timestamp:

Dec 1, 2020, 3:39:24 PM (3 years ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

a25f64b

Parents:

41c19b4

Message:

A quick-fix to get the self-assignment bug working and some clean-up I did on the way.

File:

• src/InitTweak/FixInitNew.cpp (modified) (1 diff)

src/InitTweak/FixInitNew.cpp

@@ -413 +413 @@
         void SelfAssignChecker::previsit( const ast::ApplicationExpr * appExpr ) {
                 auto function = getFunction( appExpr );
-                if ( function->name == "?=?" ) { // doesn't use isAssignment, because ?+=?, etc. should not count as self-assignment
-                        if ( appExpr->args.size() == 2 ) {
-                                // check for structural similarity (same variable use, ignore casts, etc. - but does not look too deeply, anything looking like a function is off limits)
-                                if ( structurallySimilar( appExpr->args.front(), appExpr->args.back() ) ) {
-                                        SemanticWarning( appExpr->location, Warning::SelfAssignment, toCString( appExpr->args.front() ) );
-                                }
-                        }
+                // Doesn't use isAssignment, because ?+=?, etc. should not count as self-assignment.
+                if ( function->name == "?=?" && appExpr->args.size() == 2
+                                // Check for structural similarity (same variable use, ignore casts, etc.
+                                // (but does not look too deeply, anything looking like a function is off limits).
+                                && structurallySimilar( appExpr->args.front(), appExpr->args.back() ) ) {
+                        SemanticWarning( appExpr->location, Warning::SelfAssignment, toCString( appExpr->args.front() ) );
                 }
         }