Changeset 490db327 for src/InitTweak

Timestamp:

Nov 15, 2017, 2:01:08 PM (8 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, stuck-waitfor-destruct, with_gc

Children:

20632a2

Parents:

c95b115 (diff), 6d2386e (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' into unique-variable-renaming

Location:

src/InitTweak

Files:

• GenInit.cc (modified) (3 diffs)
• InitTweak.cc (modified) (3 diffs)

src/InitTweak/GenInit.cc

@@ -214 +214 @@
                 }
                 // a type is managed if it appears in the map of known managed types, or if it contains any polymorphism (is a type variable or generic type containing a type variable)
-                return managedTypes.find( SymTab::Mangler::mangle( type ) ) != managedTypes.end() || GenPoly::isPolyType( type );
+                return managedTypes.find( SymTab::Mangler::mangleConcrete( type ) ) != managedTypes.end() || GenPoly::isPolyType( type );
         }
 
@@ -232 +232 @@
                         Type * type = InitTweak::getPointerBase( params.front()->get_type() );
                         assert( type );
-                        managedTypes.insert( SymTab::Mangler::mangle( type ) );
+                        managedTypes.insert( SymTab::Mangler::mangleConcrete( type ) );
                 }
         }
@@ -242 +242 @@
                         if ( ObjectDecl * field = dynamic_cast< ObjectDecl * >( member ) ) {
                                 if ( isManaged( field ) ) {
+                                        // generic parameters should not play a role in determining whether a generic type is constructed - construct all generic types, so that
+                                        // polymorphic constructors make generic types managed types
                                         StructInstType inst( Type::Qualifiers(), aggregateDecl );
-                                        managedTypes.insert( SymTab::Mangler::mangle( &inst ) );
+                                        managedTypes.insert( SymTab::Mangler::mangleConcrete( &inst ) );
                                         break;
                                 }

src/InitTweak/InitTweak.cc

@@ -98 +98 @@
         class InitExpander::ExpanderImpl {
         public:
+                virtual ~ExpanderImpl() = default;
                 virtual std::list< Expression * > next( std::list< Expression * > & indices ) = 0;
                 virtual Statement * buildListInit( UntypedExpr * callExpr, std::list< Expression * > & indices ) = 0;
@@ -105 +106 @@
         public:
                 InitImpl( Initializer * init ) : init( init ) {}
+                virtual ~InitImpl() = default;
 
                 virtual std::list< Expression * > next( __attribute((unused)) std::list< Expression * > & indices ) {
@@ -121 +123 @@
         public:
                 ExprImpl( Expression * expr ) : arg( expr ) {}
-
-                ~ExprImpl() { delete arg; }
+                virtual ~ExprImpl() { delete arg; }
 
                 virtual std::list< Expression * > next( std::list< Expression * > & indices ) {