Changeset 44940ee for src/Validate/Autogen.cpp

Timestamp:

Feb 25, 2026, 12:56:30 AM (33 hours ago)

Author:

Matthew Au-Yeung <mw2auyeu@…>

Branches:

stuck-waitfor-destruct

Children:

88bb0b4

Parents:

a0548c2

Message:

Revert "Add a generated hash to fix stuck waitfor comparing static inline mutex destructors"

This reverts commit a30fceb1a73c4ef2bbee39a2b5406da881f51111.

File:

• src/Validate/Autogen.cpp (modified) (1 diff)

src/Validate/Autogen.cpp

@@ -402 +402 @@
         }
 
-        return genProto( "^?{}", { dst }, {} );
+        ast::FunctionDecl * decl = genProto( "^?{}", { dst }, {} );
+        // For concurrent types, remove static storage and inline specifier, and add
+        // cfa_linkonce attribute so the destructor has external linkage with linkonce
+        // semantics. This is required for waitfor to work correctly across translation
+        // units - the function pointer must be the same everywhere, and cfa_linkonce
+        // ensures only one definition survives linking.
+        if ( isConcurrentType() ) {
+                auto mut = ast::mutate( decl );
+                mut->storage = ast::Storage::Classes();
+                mut->funcSpec = ast::Function::Specs();
+                mut->attributes.push_back( new ast::Attribute( "cfa_linkonce" ) );
+        }
+        return decl;
 }