Changeset 4389966 for src/GenPoly/InstantiateGeneric.cc

Timestamp:

Dec 15, 2015, 4:14:01 PM (10 years ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, gc_noraii, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, string, with_gc

Children:

5f6c42c

Parents:

cf16f94 (diff), 78dd0da (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

fix comment

File:

• src/GenPoly/InstantiateGeneric.cc (modified) (11 diffs)

src/GenPoly/InstantiateGeneric.cc

@@ -44 +44 @@
                 ConcreteType(const ConcreteType& that) : base(that.base), params() { cloneAll(that.params, params); }
 
-                /// Extracts types from a list of Expression* (which should be TypeExpr*)
-                ConcreteType(AggregateDecl *_base, const std::list< Expression* >& _params) : base(_base), params() {
-                        for ( std::list< Expression* >::const_iterator it = _params.begin(); it != _params.end(); ++it ) {
-                                TypeExpr *param = dynamic_cast< TypeExpr* >(*it);
-                                assert(param && "Aggregate parameters should be type expressions");
-                                params.push_back( param->get_type()->clone() );
+                /// Extracts types from a list of TypeExpr*
+                ConcreteType(AggregateDecl *_base, const std::list< TypeExpr* >& _params) : base(_base), params() {
+                        for ( std::list< TypeExpr* >::const_iterator param = _params.begin(); param != _params.end(); ++param ) {
+                                params.push_back( (*param)->get_type()->clone() );
                         }
                 }
@@ -66 +64 @@
 
                 bool operator== (const ConcreteType& that) const {
+                        if ( base != that.base ) return false;
+
                         SymTab::Indexer dummy;
-
-                        if ( base != that.base ) return false;
                         if ( params.size() != that.params.size() ) return false;
                         for ( std::list< Type* >::const_iterator it = params.begin(), jt = that.params.begin(); it != params.end(); ++it, ++jt ) {
@@ -79 +77 @@
                 std::list< Type* > params;  ///< Instantiation parameters
         };
-
+        
         /// Maps a concrete type to the instantiated struct type, accounting for scope
         class InstantiationMap {
-                /// Pair of concrete type and declaration that instantiates it
-                typedef std::pair< ConcreteType, AggregateDecl* > Instantiation;
+                /// Instantiation of a generic type, with key information to find it
+                struct Instantiation {
+                        ConcreteType key;     ///< Instantiation parameters for this type
+                        AggregateDecl *decl;  ///< Declaration of the instantiated generic type
+
+                        Instantiation() : key(), decl(0) {}
+                        Instantiation(const ConcreteType &_key, AggregateDecl *_decl) : key(_key), decl(_decl) {}
+                };
                 /// Map of generic types to instantiations of them
                 typedef std::map< AggregateDecl*, std::vector< Instantiation > > Scope;
@@ -107 +111 @@
                 /// Gets the declaration for the concrete instantiation of this type, assuming it has already been instantiated in the current scope.
                 /// Returns NULL on none such.
-                AggregateDecl* lookup( AggregateDecl *generic, std::list< Expression* >& params ) {
+                AggregateDecl* lookup( AggregateDecl *generic, const std::list< TypeExpr* >& params ) {
                         ConcreteType key(generic, params);
                         // scan scopes from innermost out
@@ -116 +120 @@
                                 // look through instantiations for matches to concrete type
                                 for ( std::vector< Instantiation >::const_iterator inst = insts->second.begin(); inst != insts->second.end(); ++inst ) {
-                                        if ( inst->first == key ) return inst->second;
+                                        if ( inst->key == key ) return inst->decl;
                                 }
                         }
@@ -123 +127 @@
                 }
         public:
-                StructDecl* lookup( StructInstType *inst ) { return (StructDecl*)lookup( inst->get_baseStruct(), inst->get_parameters() ); }
-                UnionDecl* lookup( UnionInstType *inst ) { return (UnionDecl*)lookup( inst->get_baseUnion(), inst->get_parameters() ); }
+                StructDecl* lookup( StructInstType *inst, const std::list< TypeExpr* > &typeSubs ) { return (StructDecl*)lookup( inst->get_baseStruct(), typeSubs ); }
+                UnionDecl* lookup( UnionInstType *inst, const std::list< TypeExpr* > &typeSubs ) { return (UnionDecl*)lookup( inst->get_baseUnion(), typeSubs ); }
 
         private:
                 /// Adds a declaration for a concrete type to the current scope
-                void insert( AggregateDecl *generic, std::list< Expression* >& params, AggregateDecl *decl ) {
+                void insert( AggregateDecl *generic, const std::list< TypeExpr* > &params, AggregateDecl *decl ) {
                         ConcreteType key(generic, params);
-                        scopes.back()[generic].push_back( std::make_pair( key, decl ) );
+                        scopes.back()[generic].push_back( Instantiation( key, decl ) );
                 }
         public:
-                void insert( StructInstType *inst, StructDecl *decl ) { insert( inst->get_baseStruct(), inst->get_parameters(), decl ); }
-                void insert( UnionInstType *inst, UnionDecl *decl ) { insert( inst->get_baseUnion(), inst->get_parameters(), decl ); }
+                void insert( StructInstType *inst, const std::list< TypeExpr* > &typeSubs, StructDecl *decl ) { insert( inst->get_baseStruct(), typeSubs, decl ); }
+                void insert( UnionInstType *inst, const std::list< TypeExpr* > &typeSubs, UnionDecl *decl ) { insert( inst->get_baseUnion(), typeSubs, decl ); }
         };
 
         /// Mutator pass that replaces concrete instantiations of generic types with actual struct declarations, scoped appropriately
         class Instantiate : public DeclMutator {
+                /// Map of (generic type, parameter list) pairs to concrete type instantiations
                 InstantiationMap instantiations;
+                /// Namer for concrete types
                 UniqueName typeNamer;
 
@@ -147 +153 @@
                 virtual Type* mutate( StructInstType *inst );
                 virtual Type* mutate( UnionInstType *inst );
+
+//              virtual Expression* mutate( MemberExpr *memberExpr );
                 
                 virtual void doBeginScope();
@@ -157 +165 @@
         }
 
-        /// Substitutes types of members of in according to baseParams => params, appending the result to out
-        void substituteMembers( const std::list< Declaration* >& in,
-                                                        const std::list< TypeDecl * >& baseParams, const std::list< Expression* >& params,
+        /// Makes substitutions of params into baseParams; returns true if all parameters substituted for a concrete type
+        bool makeSubstitutions( const std::list< TypeDecl* >& baseParams, const std::list< Expression* >& params, std::list< TypeExpr* >& out ) {
+                bool allConcrete = true;  // will finish the substitution list even if they're not all concrete
+
+                // substitute concrete types for given parameters, and incomplete types for placeholders
+                std::list< TypeDecl* >::const_iterator baseParam = baseParams.begin();
+                std::list< Expression* >::const_iterator param = params.begin();
+                for ( ; baseParam != baseParams.end() && param != params.end(); ++baseParam, ++param ) {
+//                      switch ( (*baseParam)->get_kind() ) {
+//                      case TypeDecl::Any: {   // any type is a valid substitution here; complete types can be used to instantiate generics
+                                TypeExpr *paramType = dynamic_cast< TypeExpr* >( *param );
+                                assert(paramType && "Aggregate parameters should be type expressions");
+                                out.push_back( paramType->clone() );
+                                // check that the substituted type isn't a type variable itself
+                                if ( dynamic_cast< TypeInstType* >( paramType->get_type() ) ) {
+                                        allConcrete = false;
+                                }
+//                              break;
+//                      }
+//                      case TypeDecl::Dtype:  // dtype can be consistently replaced with void [only pointers, which become void*]
+//                              out.push_back( new TypeExpr( new VoidType( Type::Qualifiers() ) ) );
+//                              break;
+//                      case TypeDecl::Ftype:  // pointer-to-ftype can be consistently replaced with void (*)(void) [similar to dtype]
+//                              out.push_back( new TypeExpr( new FunctionType( Type::Qualifiers(), false ) ) );
+//                              break;
+//                      }
+                }
+
+                // if any parameters left over, not done
+                if ( baseParam != baseParams.end() ) return false;
+//              // if not enough parameters given, substitute remaining incomplete types for placeholders
+//              for ( ; baseParam != baseParams.end(); ++baseParam ) {
+//                      switch ( (*baseParam)->get_kind() ) {
+//                      case TypeDecl::Any:    // no more substitutions here, fail early
+//                              return false;
+//                      case TypeDecl::Dtype:  // dtype can be consistently replaced with void [only pointers, which become void*]
+//                              out.push_back( new TypeExpr( new VoidType( Type::Qualifiers() ) ) );
+//                              break;
+//                      case TypeDecl::Ftype:  // pointer-to-ftype can be consistently replaced with void (*)(void) [similar to dtype]
+//                              out.push_back( new TypeExpr( new FunctionType( Type::Qualifiers(), false ) ) );
+//                              break;
+//                      }
+//              }
+
+                return allConcrete;
+        }
+
+        /// Substitutes types of members of in according to baseParams => typeSubs, appending the result to out
+        void substituteMembers( const std::list< Declaration* >& in, const std::list< TypeDecl* >& baseParams, const std::list< TypeExpr* >& typeSubs, 
                                                     std::list< Declaration* >& out ) {
                 // substitute types into new members
-                TypeSubstitution subs( baseParams.begin(), baseParams.end(), params.begin() );
+                TypeSubstitution subs( baseParams.begin(), baseParams.end(), typeSubs.begin() );
                 for ( std::list< Declaration* >::const_iterator member = in.begin(); member != in.end(); ++member ) {
                         Declaration *newMember = (*member)->clone();
@@ -178 +232 @@
                 // exit early if no need for further mutation
                 if ( inst->get_parameters().empty() ) return inst;
+                assert( inst->get_baseParameters() && "Base struct has parameters" );
+
+                // check if type can be concretely instantiated; put substitutions into typeSubs
+                std::list< TypeExpr* > typeSubs;
+                if ( ! makeSubstitutions( *inst->get_baseParameters(), inst->get_parameters(), typeSubs ) ) {
+                        deleteAll( typeSubs );
+                        return inst;
+                }
                 
                 // make concrete instantiation of generic type
-                StructDecl *concDecl = instantiations.lookup( inst );
+                StructDecl *concDecl = instantiations.lookup( inst, typeSubs );
                 if ( ! concDecl ) {
-                        assert( inst->get_baseParameters() && "Base struct has parameters" );
                         // set concDecl to new type, insert type declaration into statements to add
                         concDecl = new StructDecl( typeNamer.newName( inst->get_name() ) );
-                        substituteMembers( inst->get_baseStruct()->get_members(),
-                                                                *inst->get_baseParameters(), inst->get_parameters(),
-                                                                concDecl->get_members() );
+                        substituteMembers( inst->get_baseStruct()->get_members(), *inst->get_baseParameters(), typeSubs,        concDecl->get_members() );
                         DeclMutator::addDeclaration( concDecl );
-                        instantiations.insert( inst, concDecl );
+                        instantiations.insert( inst, typeSubs, concDecl );
                 }
                 StructInstType *newInst = new StructInstType( inst->get_qualifiers(), concDecl->get_name() );
                 newInst->set_baseStruct( concDecl );
+
+                deleteAll( typeSubs );
                 delete inst;
                 return newInst;
@@ -205 +266 @@
                 // exit early if no need for further mutation
                 if ( inst->get_parameters().empty() ) return inst;
-
+                assert( inst->get_baseParameters() && "Base union has parameters" );
+
+                // check if type can be concretely instantiated; put substitutions into typeSubs
+                std::list< TypeExpr* > typeSubs;
+                if ( ! makeSubstitutions( *inst->get_baseParameters(), inst->get_parameters(), typeSubs ) ) {
+                        deleteAll( typeSubs );
+                        return inst;
+                }
+                
                 // make concrete instantiation of generic type
-                UnionDecl *concDecl = instantiations.lookup( inst );
+                UnionDecl *concDecl = instantiations.lookup( inst, typeSubs );
                 if ( ! concDecl ) {
                         // set concDecl to new type, insert type declaration into statements to add
-                        assert( inst->get_baseParameters() && "Base union has parameters" );
                         concDecl = new UnionDecl( typeNamer.newName( inst->get_name() ) );
-                        substituteMembers( inst->get_baseUnion()->get_members(),
-                                                                *inst->get_baseParameters(), inst->get_parameters(),
-                                                                concDecl->get_members() );
+                        substituteMembers( inst->get_baseUnion()->get_members(), *inst->get_baseParameters(), typeSubs, concDecl->get_members() );
                         DeclMutator::addDeclaration( concDecl );
-                        instantiations.insert( inst, concDecl );
+                        instantiations.insert( inst, typeSubs, concDecl );
                 }
                 UnionInstType *newInst = new UnionInstType( inst->get_qualifiers(), concDecl->get_name() );
                 newInst->set_baseUnion( concDecl );
+
+                deleteAll( typeSubs );
                 delete inst;
                 return newInst;
         }
+
+//      /// Gets the base struct or union declaration for a member expression; NULL if not applicable
+//      AggregateDecl* getMemberBaseDecl( MemberExpr *memberExpr ) {
+//              // get variable for member aggregate
+//              VariableExpr *varExpr = dynamic_cast< VariableExpr* >( memberExpr->get_aggregate() );
+//              if ( ! varExpr ) return NULL;
+// 
+//              // get object for variable
+//              ObjectDecl *objectDecl = dynamic_cast< ObjectDecl* >( varExpr->get_var() );
+//              if ( ! objectDecl ) return NULL;
+// 
+//              // get base declaration from object type
+//              Type *objectType = objectDecl->get_type();
+//              StructInstType *structType = dynamic_cast< StructInstType* >( objectType );
+//              if ( structType ) return structType->get_baseStruct();
+//              UnionInstType *unionType = dynamic_cast< UnionInstType* >( objectType );
+//              if ( unionType ) return unionType->get_baseUnion();
+// 
+//              return NULL;
+//      }
+// 
+//      /// Finds the declaration with the given name, returning decls.end() if none such
+//      std::list< Declaration* >::const_iterator findDeclNamed( const std::list< Declaration* > &decls, const std::string &name ) {
+//              for( std::list< Declaration* >::const_iterator decl = decls.begin(); decl != decls.end(); ++decl ) {
+//                      if ( (*decl)->get_name() == name ) return decl;
+//              }
+//              return decls.end();
+//      }
+//      
+//      Expression* Instantiate::mutate( MemberExpr *memberExpr ) {
+//              // mutate, exiting early if no longer MemberExpr
+//              Expression *expr = Mutator::mutate( memberExpr );
+//              memberExpr = dynamic_cast< MemberExpr* >( expr );
+//              if ( ! memberExpr ) return expr;
+// 
+//              // get declaration of member and base declaration of member, exiting early if not found
+//              AggregateDecl *memberBase = getMemberBaseDecl( memberExpr );
+//              if ( ! memberBase ) return memberExpr;
+//              DeclarationWithType *memberDecl = memberExpr->get_member();
+//              std::list< Declaration* >::const_iterator baseIt = findDeclNamed( memberBase->get_members(), memberDecl->get_name() );
+//              if ( baseIt == memberBase->get_members().end() ) return memberExpr;
+//              DeclarationWithType *baseDecl = dynamic_cast< DeclarationWithType* >( *baseIt );
+//              if ( ! baseDecl ) return memberExpr;
+// 
+//              // check if stated type of the member is not the type of the member's declaration; if so, need a cast
+//              // this *SHOULD* be safe, I don't think anything but the void-replacements I put in for dtypes would make it past the typechecker
+//              SymTab::Indexer dummy;
+//              if ( ResolvExpr::typesCompatible( memberDecl->get_type(), baseDecl->get_type(), dummy ) ) return memberExpr;
+//              else return new CastExpr( memberExpr, memberDecl->get_type() );
+//      }
         
         void Instantiate::doBeginScope() {
                 DeclMutator::doBeginScope();
-                // push a new concrete type scope
                 instantiations.beginScope();
         }
@@ -232 +349 @@
         void Instantiate::doEndScope() {
                 DeclMutator::doEndScope();
-                // pop the last concrete type scope
                 instantiations.endScope();
         }