Changeset 3100754 for src

Timestamp:

Oct 29, 2020, 5:21:03 PM (5 years ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

45444c3, 4ae78c1

Parents:

c6c682cf

Message:

Used the new isInFunction in GenPoly/Specialize instead of a second pass. Might be faster and it is all in one place.

File:

• src/GenPoly/Specialize.cc (modified) (2 diffs)

src/GenPoly/Specialize.cc

@@ -218 +218 @@
                 thunkFunc->get_attributes().push_back( new Attribute( "unused" ) );
 
+                // Thunks at the global level must be static to avoid collisions between files.
+                // (Conversly thunks inside a function must be unique and not static.)
+                thunkFunc->storageClasses.is_static = !isInFunction();
+
                 // thread thunk parameters into call to actual function, naming thunk parameters as we go
                 UniqueName paramNamer( paramPrefix );
@@ -321 +325 @@
         }
 
-        // Fold it into Specialize if we find a good way.
-        struct StaticThunks final : public WithShortCircuiting {
-                void previsit( Declaration * ) {
-                        visit_children = false;
-                }
-                void postvisit( FunctionDecl * decl ) {
-                        if ( isPrefix( decl->name, "_thunk" ) ) {
-                                decl->storageClasses.is_static = true;
-                        }
-                }
-        };
-
         void convertSpecializations( std::list< Declaration* >& translationUnit ) {
                 PassVisitor<Specialize> spec;
                 mutateAll( translationUnit, spec );
-                PassVisitor<StaticThunks> staticThunks;
-                acceptAll( translationUnit, staticThunks );
         }
 } // namespace GenPoly