Changeset 24de7b1 for src/SynTree/GcTracer.h

Timestamp:

Apr 16, 2018, 3:21:17 PM (6 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

new-env, with_gc

Children:

fb97252f

Parents:

6f81db3

Message:

Fix more missing visits in GcTracer?, add cycle detection back in, ensure mark isn't broken by defaulted GC_Object copy and assign

File:

• src/SynTree/GcTracer.h (modified) (3 diffs)

src/SynTree/GcTracer.h

@@ -38 +38 @@
         void previsit( BaseSyntaxNode * node ) {
                 // skip tree if already seen
-                // xxx - this should be uncommented (it breaks object cycles), but at the moment it seems 
-                // like the object cycles don't happen and other bugs do
-                // if ( node->mark == gc.mark ) {
-                //      visit_children = false;
-                //      return;
-                // }
+                if ( node->mark == gc.mark ) {
+                        visit_children = false;
+                        return;
+                }
 
                 // mark node
@@ -50 +48 @@
 
         // add visits left out by PassVisitor
+
+        void postvisit( Constant* con ) {
+                maybeAccept( con->get_type(), *visitor );
+        }
 
         void postvisit( Expression* expr ) {
@@ -58 +60 @@
                 postvisit( static_cast<Expression*>(expr) );
                 maybeAccept( expr->function, *visitor );
+        }
+
+        void postvisit( VariableExpr* expr ) {
+                postvisit( static_cast<Expression*>(expr) );
+                maybeAccept( expr->var, *visitor );  // not in PassVisitor because it causes cycle
         }