Changeset 22226e4 for libcfa/src/concurrency/kernel/startup.cfa

Timestamp:

Mar 18, 2022, 12:42:39 PM (2 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, enum, master, pthread-emulation, qualifiedEnum

Children:

0b4ddb71, 51239d1b

Parents:

3bc69f2

Message:

Tentative fix for spurious deadlock in some concurrency tests

File:

• libcfa/src/concurrency/kernel/startup.cfa (modified) (9 diffs)

libcfa/src/concurrency/kernel/startup.cfa

@@ -33 +33 @@
 // CFA Includes
 #include "kernel/private.hfa"
+#include "iofwd.hfa"
 #include "startup.hfa"                                  // STARTUP_PRIORITY_XXX
 #include "limits.hfa"
@@ -97 +98 @@
 extern void __kernel_alarm_startup(void);
 extern void __kernel_alarm_shutdown(void);
+extern void __cfa_io_start( processor * );
+extern void __cfa_io_stop ( processor * );
 
 //-----------------------------------------------------------------------------
@@ -111 +114 @@
 KERNEL_STORAGE(__stack_t,            mainThreadCtx);
 KERNEL_STORAGE(__scheduler_RWLock_t, __scheduler_lock);
+KERNEL_STORAGE(eventfd_t,            mainIdleEventFd);
+KERNEL_STORAGE(io_future_t,          mainIdleFuture);
 #if !defined(__CFA_NO_STATISTICS__)
 KERNEL_STORAGE(__stats_t, mainProcStats);
@@ -224 +229 @@
         (*mainProcessor){};
 
+        mainProcessor->idle_wctx.rdbuf = &storage_mainIdleEventFd;
+        mainProcessor->idle_wctx.ftr   = (io_future_t*)&storage_mainIdleFuture;
+        /* paranoid */ verify( sizeof(storage_mainIdleEventFd) == sizeof(eventfd_t) );
+
         register_tls( mainProcessor );
+        __cfa_io_start( mainProcessor );
 
         // Start by initializing the main thread
@@ -304 +314 @@
         mainProcessor->local_data = 0p;
 
+        __cfa_io_stop( mainProcessor );
         unregister_tls( mainProcessor );
 
@@ -355 +366 @@
         register_tls( proc );
 
+        __cfa_io_start( proc );
+
+        // used for idle sleep when io_uring is present
+        io_future_t future;
+        eventfd_t idle_buf;
+        proc->idle_wctx.ftr = &future;
+        proc->idle_wctx.rdbuf = &idle_buf;
+
+
         // SKULLDUGGERY: We want to create a context for the processor coroutine
         // which is needed for the 2-step context switch. However, there is no reason
@@ -381 +401 @@
         // Main routine of the core returned, the core is now fully terminated
         __cfadbg_print_safe(runtime_core, "Kernel : core %p main ended (%p)\n", proc, &proc->runner);
+
+        __cfa_io_stop( proc );
 
         #if !defined(__CFA_NO_STATISTICS__)
@@ -532 +554 @@
         this.local_data = 0p;
 
-        this.idle_fd = eventfd(0, 0);
-        if (idle_fd < 0) {
+        idle_wctx.evfd = eventfd(0, 0);
+        if (idle_wctx.evfd < 0) {
                 abort("KERNEL ERROR: PROCESSOR EVENTFD - %s\n", strerror(errno));
         }
 
-        this.idle_wctx.fd = 0;
+        idle_wctx.sem = 0;
 
         // I'm assuming these two are reserved for standard input and output
         // so I'm using them as sentinels with idle_wctx.
-        /* paranoid */ verify( this.idle_fd != 0 );
-        /* paranoid */ verify( this.idle_fd != 1 );
+        /* paranoid */ verify( idle_wctx.evfd != 0 );
+        /* paranoid */ verify( idle_wctx.evfd != 1 );
 
         #if !defined(__CFA_NO_STATISTICS__)
@@ -554 +576 @@
 // Not a ctor, it just preps the destruction but should not destroy members
 static void deinit(processor & this) {
-        close(this.idle_fd);
+        close(this.idle_wctx.evfd);
 }