Changeset 204358b for src/AST/porting.md

Timestamp:

May 16, 2019, 2:57:41 PM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

b336af9

Parents:

10248ae0 (diff), f3cc5b6 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

File:

• src/AST/porting.md (modified) (7 diffs)

src/AST/porting.md

@@ -6 +6 @@
   * specialization: strong pointer `ast::ptr<T>` is used for an ownership relationship
   * specialization: weak pointer `ast::readonly<T>` is used for an observation relationship
-  * added `ast::ptr_base<T,R>::as<S>()` with same semantics as `dynamic_cast<S*>(p)`
+* added `ast::ptr_base<T,R>::as<S>()` with same semantics as `dynamic_cast<S*>(p)`
+* added `N * ast::ptr_base<N,R>::set_and_mutate( const N * n )`
+  * takes ownership of `n`, then returns a mutable version owned by this pointer
+  * Some debate on whether this is a good approach:
+    * makes an easy path to cloning, which we were trying to eliminate
+      * counter-point: these are all mutating clones rather than lifetime-preserving clones, and thus "necessary" (for some definition)
+    * existing uses:
+      * `VariableExpr::VariableExpr`, `UntypedExpr::createDeref`
+        * both involve grabbing a type from elsewhere and making an `lvalue` copy of it
+        * could potentially be replaced by a view class something like this:
+          ```
+          template<unsigned Quals>
+          class AddQualifiersType final : public Type {
+            readonly<Type> base;
+            // ...
+          };
+          ```
+          * requires all `qualifiers` use (and related helpers) to be virtual, non-zero overhead
+          * also subtle semantic change, where mutations to the source decl now change the viewing expression
 
 ## Visitors ##
@@ -106 +124 @@
   * allows `newObject` as just default settings
 
+`NamedTypeDecl`
+* `parameters` => `params`
+
 `TypeDecl`
 * moved `TypeDecl::Kind` to `ast::TypeVar::Kind`
+
+`AggregateDecl`
+* `parameters` => `params`
 
 `EnumDecl`
@@ -115 +139 @@
 * Merged `inferParams`/`resnSlots` into union, as suggested by comment in old version
   * does imply get_/set_ API, and some care about moving backward
+* added constructor that sets result, for benefit of types that set it directly
+
+`ApplicationExpr`
+* `function` => `func`
+
+`UntypedExpr`
+* `function` => `func`
+* removed `begin_args()` in favour of `args.begin()`
+
+`MemberExpr`
+* **TODO** port setup of `result` in constructor
+
+`ConstantExpr`
+* inlined features of `Constant`, never used elsewhere, so removed `Constant`
+  * `Constant Constant::from_int(int)` etc. => `ConstantExpr * ConstantExpr::from_int(CodeLocation, int)`
+    * allocates new `ConstantExpr`, consistent with all existing uses
+
+`SizeofExpr`, `AlignofExpr`
+* `isType` deprecated in favour of boolean check on `type`
+  * all existing uses assume `type` set if true and don't use `expr`
+
+`AttrExpr`
+* did not port due to feature deprecation (e.g. `expr@attribute`)
+
+`LogicalExpr`
+* un-defaulted constructor parameter determining `&&` or `||`
 
 `Init`
@@ -148 +198 @@
 `Type`
 * `CV::Qualifiers` moved to end of constructor parameter list, defaulted to `{}`
+  * removed getter, setter in favour of public `qualifiers` field
   * `ReferenceToType` puts a defaulted list of attributes after qualifiers
 * `forall` field split off into `ParameterizedType` subclass
@@ -160 +211 @@
   * `getAggr()` => `aggr()`
     * also now returns `const AggregateDecl *`
-* `genericSubstitution()` moved to own visitor **TODO** write
+* `genericSubstitution()` moved to own visitor in `AST/GenericSubstitution.hpp` **TODO** write
 
 `BasicType`
@@ -167 +218 @@
 `ReferenceToType`
 * deleted `get_baseParameters()` from children
-  * replace with `aggr() ? aggr()->parameters : nullptr`
+  * replace with `aggr() ? aggr()->params : nullptr`
+* `parameters` => `params`
 * hoisted `lookup` implementation into parent, made non-virtual
   * also changed to return vector rather than filling; change back if any great win for reuse
@@ -178 +230 @@
 
 `FunctionType`
+* `returnVals` => `returns`
+* `parameters` => `params`
 * `bool isVarArgs;` => `enum ArgumentFlag { FixedArgs, VariableArgs }; ArgumentFlag isVarArgs;`