Changeset 19a8c40 for src/Validate

Timestamp:

Nov 14, 2022, 11:47:23 AM (18 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, ast-experimental, master

Children:

63be3387, c1fb3903

Parents:

7491f97

Message:

Some clean-up I had stashed from before I knew the InlineMemberDecl? clean-up was underway.

File:

• src/Validate/EnumAndPointerDecay.cpp (modified) (1 diff)

src/Validate/EnumAndPointerDecay.cpp

@@ -41 +41 @@
         auto mut = ast::mutate( decl );
         std::vector<ast::ptr<ast::Decl>> buffer;
-        for ( auto it = decl->members.begin(); it != decl->members.end(); ++it ) {
-                if ( ast::ObjectDecl const * object = (*it).as<ast::ObjectDecl>() ) {
-                        buffer.push_back( ast::mutate_field( object, &ast::ObjectDecl::type, new ast::EnumInstType( decl, ast::CV::Const ) ) );
-                } else if ( ast::InlineMemberDecl const * value = (*it).as<ast::InlineMemberDecl>() ) {
+        for ( auto member : decl->members ) {
+                if ( ast::ObjectDecl const * object = member.as<ast::ObjectDecl>() ) {
+                        buffer.push_back( ast::mutate_field( object,
+                                &ast::ObjectDecl::type,
+                                new ast::EnumInstType( decl, ast::CV::Const ) ) );
+                } else if ( auto value = member.as<ast::InlineMemberDecl>() ) {
                         if ( auto targetEnum = symtab.lookupEnum( value->name ) ) {
-                                for ( auto singleMember : targetEnum->members ) {
-                                        auto copyingMember = singleMember.as<ast::ObjectDecl>();
+                                for ( auto enumMember : targetEnum->members ) {
+                                        auto enumObject = enumMember.strict_as<ast::ObjectDecl>();
                                         buffer.push_back( new ast::ObjectDecl(
-                                                value->location, // use the "inline" location
-                                                copyingMember->name,
+                                                // Get the location from the "inline" declaration.
+                                                value->location,
+                                                enumObject->name,
+                                                // Construct a new EnumInstType as the type.
                                                 new ast::EnumInstType( decl, ast::CV::Const ),
-                                                // Construct a new EnumInstType as the type
-                                                copyingMember->init,
-                                                copyingMember->storage,
-                                                copyingMember->linkage,
-                                                copyingMember->bitfieldWidth,
+                                                enumObject->init,
+                                                enumObject->storage,
+                                                enumObject->linkage,
+                                                enumObject->bitfieldWidth,
                                                 {},
-                                                copyingMember->funcSpec
+                                                enumObject->funcSpec
                                         ) );
                                 }