Changeset 14c0f7b for src/AST/Create.cpp

Timestamp:

Jul 31, 2023, 11:25:51 AM (11 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

f496046

Parents:

e0332dd

Message:

Added invariant to check that referenced declarations are in scope. This one took a while, I don't remember why forall pointer decay is involved.

File:

• src/AST/Create.cpp (modified) (1 diff)

src/AST/Create.cpp

@@ -42 +42 @@
                 return nullptr;
         }
-        return new ast::FunctionDecl( decl->location,
-                decl->name,
-                vectorCopy( decl->type_params ),
-                vectorCopy( decl->assertions ),
-                vectorCopy( decl->params ),
-                vectorCopy( decl->returns ),
-                nullptr,
-                decl->storage,
-                decl->linkage,
-                vectorCopy( decl->attributes ),
-                decl->funcSpec,
-                decl->type->isVarArgs
-        );
+        // The cast and changing the original should be safe as long as the
+        // change is reverted before anything else sees it. It's also faster.
+        FunctionDecl * mutDecl = const_cast<FunctionDecl *>( decl );
+        CompoundStmt const * stmts = mutDecl->stmts.release();
+        FunctionDecl * copy = deepCopy( mutDecl );
+        mutDecl->stmts = stmts;
+        return copy;
 }