Changeset 111a8af8 for src/ResolvExpr/TypeEnvironment.h

Timestamp:

Aug 28, 2017, 5:55:54 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

5b21138

Parents:

1cb758f2

Message:

Simplify AssertionSet? comparator

File:

• src/ResolvExpr/TypeEnvironment.h (modified) (1 diff)

src/ResolvExpr/TypeEnvironment.h

@@ -28 +28 @@
 
 namespace ResolvExpr {
+        // adding this comparison operator significantly improves assertion resolution run time for
+        // some cases. The current resolution algorithm's speed partially depends on the order of
+        // assertions. Assertions which have fewer possible matches should appear before
+        // assertions which have more possible matches. This seems to imply that this could
+        // be further improved by providing an indexer as an additional argument and ordering based
+        // on the number of matches of the same kind (object, function) for the names of the
+        // declarations.
+        //
+        // I've seen a TU go from 54 minutes to 1 minute 34 seconds with the addition of this comparator.
         struct AssertCompare {
-                bool operator()( DeclarationWithType * d1, DeclarationWithType * d2 ) const;
+                bool operator()( DeclarationWithType * d1, DeclarationWithType * d2 ) const {
+                        int cmp = d1->get_name().compare( d2->get_name() );
+                        return cmp < 0 ||
+                                ( cmp == 0 && d1->get_type() < d2->get_type() );
+                }
         };
         struct AssertionSetValue {