Changeset 0348fd8 for libcfa/src

Timestamp:

Jan 4, 2023, 1:43:50 PM (2 years ago)

Author:

caparsons <caparson@…>

Branches:

ADT, ast-experimental, master

Children:

d99a716

Parents:

df9e412

Message:

fixed clh bug where you couldn't hold more than 1 clh lock at once

Location:

libcfa/src/concurrency

Files:

• invoke.h (modified) (1 diff)
• locks.hfa (modified) (2 diffs)

libcfa/src/concurrency/invoke.h

@@ -215 +215 @@
                 struct __thread_user_link cltr_link;
 
-                // used to store state between clh lock/unlock
-                volatile bool * clh_prev;
-
                 // used to point to this thd's current clh node
                 volatile bool * clh_node;

libcfa/src/concurrency/locks.hfa

@@ -228 +228 @@
 struct clh_lock {
         volatile bool * volatile tail;
+    volatile bool * volatile head;
 };
 
@@ -237 +238 @@
         *(curr_thd->clh_node) = false;
         volatile bool * prev = __atomic_exchange_n((bool **)(&l.tail), (bool *)(curr_thd->clh_node), __ATOMIC_SEQ_CST);
-        while(!__atomic_load_n(prev, __ATOMIC_ACQUIRE)) Pause();
-        curr_thd->clh_prev = prev;
+        while(!__atomic_load_n(prev, __ATOMIC_SEQ_CST)) Pause();
+    __atomic_store_n((bool **)(&l.head), (bool *)curr_thd->clh_node, __ATOMIC_SEQ_CST);
+    curr_thd->clh_node = prev;
 }
 
 static inline void unlock(clh_lock & l) {
-        thread$ * curr_thd = active_thread();
-        __atomic_store_n(curr_thd->clh_node, true, __ATOMIC_RELEASE);
-        curr_thd->clh_node = curr_thd->clh_prev;
+        __atomic_store_n((bool *)(l.head), true, __ATOMIC_SEQ_CST);
 }