Changeset ffe2fad for libcfa/src/concurrency

Timestamp:

Apr 23, 2019, 2:41:32 PM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

673cd63

Parents:

8c3a0336

Message:

Fixed several warnings in libcfa

Location:

libcfa/src/concurrency

Files:

• coroutine.cfa (modified) (2 diffs)
• invoke.h (modified) (1 diff)
• kernel.cfa (modified) (1 diff)

libcfa/src/concurrency/coroutine.cfa

@@ -70 +70 @@
         bool userStack = ((intptr_t)this.storage & 0x1) != 0;
         if ( ! userStack && this.storage ) {
-                *((intptr_t*)&this.storage) &= (intptr_t)-1;
+                __attribute__((may_alias)) intptr_t * istorage = (intptr_t *)&this.storage;
+                *istorage &= (intptr_t)-1;
+
                 void * storage = this.storage->limit;
                 __cfaabi_dbg_debug_do(
@@ -174 +176 @@
         this->storage->limit = storage;
         this->storage->base  = (void*)((intptr_t)storage + size);
-        *((intptr_t*)&this->storage) |= userStack ? 0x1 : 0x0;
+        __attribute__((may_alias)) intptr_t * istorage = (intptr_t*)&this->storage;
+        *istorage |= userStack ? 0x1 : 0x0;
 }
 

libcfa/src/concurrency/invoke.h

@@ -199 +199 @@
         #ifdef __cforall
         extern "Cforall" {
-                static inline struct coroutine_desc * volatile active_coroutine() { return TL_GET( this_thread )->curr_cor; }
-                static inline struct thread_desc    * volatile active_thread   () { return TL_GET( this_thread    ); }
-                static inline struct processor      * volatile active_processor() { return TL_GET( this_processor ); } // UNSAFE
+                static inline struct coroutine_desc * active_coroutine() { return TL_GET( this_thread )->curr_cor; }
+                static inline struct thread_desc    * active_thread   () { return TL_GET( this_thread    ); }
+                static inline struct processor      * active_processor() { return TL_GET( this_processor ); } // UNSAFE
 
                 static inline thread_desc * & get_next( thread_desc & this ) {

libcfa/src/concurrency/kernel.cfa

@@ -165 +165 @@
                 base      = info->base;
         }
-        *((intptr_t*)&stack.storage) |= 0x1;
+        __attribute__((may_alias)) intptr_t * istorage = (intptr_t*) &stack.storage;
+        *istorage |= 0x1;
         name = "Main Thread";
         state = Start;