Changeset fac05b3

Timestamp:

Apr 6, 2023, 4:09:24 PM (20 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, ast-experimental, master

Children:

485393c

Parents:

c468150

Message:

Removed members from TupleType?. They were only used in one place, CurrentObject?. That now has a patch to create its own imaginary members.

Location:

src

Files:

• AST/Pass.impl.hpp (modified) (1 diff)
• AST/Type.cpp (modified) (2 diffs)
• AST/Type.hpp (modified) (2 diffs)
• ResolvExpr/CurrentObject.cc (modified) (2 diffs)

src/AST/Pass.impl.hpp

@@ -2042 +2042 @@
         if ( __visit_children() ) {
                 maybe_accept( node, &TupleType::types );
-                maybe_accept( node, &TupleType::members );
         }
 

src/AST/Type.cpp

@@ -10 +10 @@
 // Created On       : Mon May 13 15:00:00 2019
 // Last Modified By : Andrew Beach
-// Last Modified On : Thu Nov 24  9:49:00 2022
-// Update Count     : 6
+// Last Modified On : Thu Apr  6 15:59:00 2023
+// Update Count     : 7
 //
 
@@ -199 +199 @@
 
 TupleType::TupleType( std::vector<ptr<Type>> && ts, CV::Qualifiers q )
-: Type( q ), types( std::move(ts) ), members() {
-        // This constructor is awkward. `TupleType` needs to contain objects so that members can be
-        // named, but members without initializer nodes end up getting constructors, which breaks
-        // things. This happens because the object decls have to be visited so that their types are
-        // kept in sync with the types listed here. Ultimately, the types listed here should perhaps
-        // be eliminated and replaced with a list-view over members. The temporary solution is to
-        // make a `ListInit` with `maybeConstructed = false`, so when the object is visited it is not
-        // constructed. Potential better solutions include:
-        //   a) Separate `TupleType` from its declarations, into `TupleDecl` and `Tuple{Inst?}Type`,
-        //      similar to the aggregate types.
-        //   b) Separate initializer nodes better, e.g. add a `MaybeConstructed` node that is replaced
-        //      by `genInit`, rather than the current boolean flag.
-        members.reserve( types.size() );
-        for ( const Type * ty : types ) {
-                members.emplace_back( new ObjectDecl{
-                        CodeLocation(), "", ty, new ListInit( CodeLocation(), {}, {}, NoConstruct ),
-                        Storage::Classes{}, Linkage::Cforall } );
-        }
-}
+: Type( q ), types( std::move(ts) ) {}
 
 bool isUnboundType(const Type * type) {

src/AST/Type.hpp

@@ -10 +10 @@
 // Created On       : Thu May 9 10:00:00 2019
 // Last Modified By : Andrew Beach
-// Last Modified On : Thu Nov 24  9:47:00 2022
-// Update Count     : 8
+// Last Modified On : Thu Apr  6 15:58:00 2023
+// Update Count     : 9
 //
 
@@ -457 +457 @@
 public:
         std::vector<ptr<Type>> types;
-        std::vector<ptr<Decl>> members;
 
         TupleType( std::vector<ptr<Type>> && ts, CV::Qualifiers q = {} );

src/ResolvExpr/CurrentObject.cc

@@ -10 +10 @@
 // Created On       : Tue Jun 13 15:28:32 2017
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Fri Jul  1 09:16:01 2022
-// Update Count     : 15
+// Last Modified On : Thu Apr  6 16:03:00 2023
+// Update Count     : 16
 //
 
@@ -899 +899 @@
 
         class TupleIterator final : public AggregateIterator {
+                MemberList * memberList;
+
+                TupleIterator( const CodeLocation & loc,
+                        const ast::TupleType * inst, MemberList * memberList )
+                : AggregateIterator(
+                        loc, "TupleIterator", toString("Tuple", inst->size()), inst, *memberList
+                ), memberList( memberList ) {}
+
+                // The two layer constructor, this helper and the destructor
+                // are all to pretend that Tuples have members (they do not).
+                static MemberList * newImaginaryMembers( const ast::TupleType * inst ) {
+                        auto ret = new MemberList();
+                        ret->reserve( inst->types.size() );
+                        for ( const ast::Type * type : inst->types ) {
+                                ret->emplace_back( new ast::ObjectDecl(
+                                        CodeLocation(), "", type,
+                                        new ast::ListInit( CodeLocation(), {}, {}, ast::NoConstruct )
+                                ) );
+                        }
+                        return ret;
+                }
+
         public:
                 TupleIterator( const CodeLocation & loc, const TupleType * inst )
-                : AggregateIterator(
-                        loc, "TupleIterator", toString("Tuple", inst->size()), inst, inst->members
-                ) {}
+                : TupleIterator( loc, inst, newImaginaryMembers( inst ) ) {}
+
+                virtual ~TupleIterator() {
+                        delete memberList;
+                }
 
                 operator bool() const override {