Changeset f9cebb5 for src/SynTree

Timestamp:

Aug 4, 2016, 4:10:06 PM (9 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

4819cac

Parents:

73bf8cf2

Message:

add gcc attributes to ObjectDecl?, hoist destructed static variables, add breaks to end of generated switch

Location:

src/SynTree

Files:

• Declaration.cc (modified) (2 diffs)
• Declaration.h (modified) (6 diffs)
• DeclarationWithType.cc (modified) (1 diff)
• FunctionDecl.cc (modified) (4 diffs)
• Label.h (modified) (1 diff)
• ObjectDecl.cc (modified) (3 diffs)

src/SynTree/Declaration.cc

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// Declaration.cc -- 
+// Declaration.cc --
 //
 // Author           : Richard C. Bilson
@@ -20 +20 @@
 #include "Initializer.h"
 #include "Type.h"
+#include "Attribute.h"
 #include "Common/utility.h"
 

src/SynTree/Declaration.h

@@ -64 +64 @@
 class DeclarationWithType : public Declaration {
   public:
-        DeclarationWithType( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage );
+        DeclarationWithType( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage, const std::list< Attribute * > & attributes );
         DeclarationWithType( const DeclarationWithType &other );
         virtual ~DeclarationWithType();
@@ -75 +75 @@
         int get_scopeLevel() const { return scopeLevel; }
         void set_scopeLevel( int newValue ) { scopeLevel = newValue; }
+
+        std::list< Attribute * >& get_attributes() { return attributes; }
+        const std::list< Attribute * >& get_attributes() const { return attributes; }
 
         virtual DeclarationWithType *clone() const = 0;
@@ -87 +90 @@
         // shadowed identifiers can be accessed
         int scopeLevel = 0;
+
+        std::list< Attribute * > attributes;
 };
 
@@ -92 +97 @@
         typedef DeclarationWithType Parent;
   public:
-        ObjectDecl( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage, Expression *bitfieldWidth, Type *type, Initializer *init, bool isInline = false, bool isNoreturn = false );
+        ObjectDecl( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage, Expression *bitfieldWidth, Type *type, Initializer *init, const std::list< Attribute * > attributes = std::list< Attribute * >(), bool isInline = false, bool isNoreturn = false );
         ObjectDecl( const ObjectDecl &other );
         virtual ~ObjectDecl();
@@ -131 +136 @@
         std::list< std::string >& get_oldIdents() { return oldIdents; }
         std::list< Declaration* >& get_oldDecls() { return oldDecls; }
-        std::list< Attribute * >& get_attributes() { return attributes; }
 
         virtual FunctionDecl *clone() const { return new FunctionDecl( *this ); }
@@ -143 +147 @@
         std::list< std::string > oldIdents;
         std::list< Declaration* > oldDecls;
-        std::list< Attribute * > attributes;
 };
 

src/SynTree/DeclarationWithType.cc

@@ -16 +16 @@
 #include "Declaration.h"
 #include "Type.h"
+#include "Attribute.h"
 #include "Common/utility.h"
 
-DeclarationWithType::DeclarationWithType( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage )
-                : Declaration( name, sc, linkage ) {
+DeclarationWithType::DeclarationWithType( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage, const std::list< Attribute * > & attributes )
+                : Declaration( name, sc, linkage ), attributes( attributes ) {
 }
 
 DeclarationWithType::DeclarationWithType( const DeclarationWithType &other )
                 : Declaration( other ), mangleName( other.mangleName ), scopeLevel( other.scopeLevel ) {
+        cloneAll( other.attributes, attributes );
 }
 
 DeclarationWithType::~DeclarationWithType() {
+        deleteAll( attributes );
 }
 

src/SynTree/FunctionDecl.cc

@@ -23 +23 @@
 
 FunctionDecl::FunctionDecl( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage, FunctionType *type, CompoundStmt *statements, bool isInline, bool isNoreturn, std::list< Attribute * > attributes )
-                : Parent( name, sc, linkage ), type( type ), statements( statements ), attributes( attributes ) {
+                : Parent( name, sc, linkage, attributes ), type( type ), statements( statements ) {
         set_isInline( isInline );
         set_isNoreturn( isNoreturn );
@@ -34 +34 @@
 FunctionDecl::FunctionDecl( const FunctionDecl &other )
         : Parent( other ), type( maybeClone( other.type ) ), statements( maybeClone( other.statements ) ) {
-                cloneAll( other.attributes, attributes );
 }
 
@@ -40 +39 @@
         delete type;
         delete statements;
-        deleteAll( attributes );
 }
 
@@ -69 +67 @@
         } // if
 
-        printAll( attributes, os, indent );
+        printAll( get_attributes(), os, indent );
 
         if ( get_storageClass() != DeclarationNode::NoStorageClass ) {

src/SynTree/Label.h

@@ -24 +24 @@
 class Label {
   public:
-        Label( const std::string & name = "", Statement * labelled = 0 ) : name( name ), labelled( labelled ) {}
+        Label( const std::string & name = "", Statement * labelled = 0, const std::list< Attribute * > & attributes = std::list< Attribute * >() ) : name( name ), labelled( labelled ), attributes( attributes ) {}
         Label( const char * name, Statement * labelled = 0 ) : name( name ), labelled( labelled ) {}
 

src/SynTree/ObjectDecl.cc

@@ -18 +18 @@
 #include "Initializer.h"
 #include "Expression.h"
+#include "Attribute.h"
 #include "Common/utility.h"
 #include "Statement.h"
 
-ObjectDecl::ObjectDecl( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage, Expression *bitfieldWidth, Type *type, Initializer *init, bool isInline, bool isNoreturn )
-        : Parent( name, sc, linkage ), type( type ), init( init ), bitfieldWidth( bitfieldWidth ) {
+ObjectDecl::ObjectDecl( const std::string &name, DeclarationNode::StorageClass sc, LinkageSpec::Type linkage, Expression *bitfieldWidth, Type *type, Initializer *init, const std::list< Attribute * > attributes, bool isInline, bool isNoreturn )
+        : Parent( name, sc, linkage, attributes ), type( type ), init( init ), bitfieldWidth( bitfieldWidth ) {
         set_isInline( isInline );
         set_isNoreturn( isNoreturn );
@@ -45 +46 @@
                 os << LinkageSpec::toString( get_linkage() ) << " ";
         } // if
+
+        printAll( get_attributes(), os, indent );
 
         if ( get_storageClass() != DeclarationNode::NoStorageClass ) {
@@ -80 +83 @@
         } // if
 
+        // xxx - should printShort print attributes?
+
         if ( get_storageClass() != DeclarationNode::NoStorageClass ) {
                 os << DeclarationNode::storageName[ get_storageClass() ] << ' ';