Changeset f988834 for src/AST

Timestamp:

Jan 19, 2024, 2:44:41 AM (2 years ago)

Author:

JiadaL <j82liang@…>

Branches:

master

Children:

ac939461

Parents:

59c8dff (diff), e8b3717 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

Location:

src/AST

Files:

• Attribute.cpp (modified) (1 diff)
• Decl.hpp (modified) (1 diff)
• Pass.proto.hpp (modified) (1 diff)

src/AST/Attribute.cpp

@@ -38 +38 @@
 
 bool Attribute::isValidOnFuncParam() const {
-        // attributes such as aligned, cleanup, etc. produce GCC errors when they appear
-        // on function parameters. Maintain here a whitelist of attribute names that are
-        // allowed to appear on parameters.
+        // Attributes produce GCC errors when they appear on function
+        // parameters. Names on the previous allow-list implementation:
+        // unused, noreturn, __vector_size__
         std::string norm = normalizedName();
-        return norm == "unused" || norm == "noreturn";
+        return norm != "aligned" && norm != "packed" && norm != "used";
 }
 

src/AST/Decl.hpp

@@ -29 +29 @@
 #include "StorageClasses.hpp"
 #include "Visitor.hpp"
-#include "Common/utility.h"
 
 // Must be included in *all* AST classes; should be #undef'd at the end of the file

src/AST/Pass.proto.hpp

@@ -19 +19 @@
 #include "Common/Iterate.hpp"
 #include "Common/Stats/Heap.h"
+#include "Common/utility.h"
 namespace ast {
         template<typename core_t> class Pass;