Changeset f866d15

Timestamp:

Sep 28, 2020, 5:00:45 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

21c3ea1

Parents:

40c81e5

Message:

test.py now warns if an .expect file is empty

Location:

tests

Files:

• pybin/tools.py (modified) (1 diff)
• test.py (modified) (1 diff)

tests/pybin/tools.py

@@ -88 +88 @@
                 raise
 
+def is_empty(fname):
+        if not os.path.isfile(fname):
+                return True
+
+        if os.stat(fname).st_size == 0:
+                return True
+
+        return False
+
 def is_ascii(fname):
         if settings.dry_run:
                 print("is_ascii: %s" % fname)
-                return True
+                return (True, "")
 
         if not os.path.isfile(fname):
-                return False
-
-        code, out = sh("file %s" % fname, output_file=subprocess.PIPE)
+                return (False, "No file")
+
+        code, out = sh("file", fname, output_file=subprocess.PIPE)
         if code != 0:
-                return False
+                return (False, "'file EXPECT' failed with code {}".format(code))
 
         match = re.search(".*: (.*)", out)
 
         if not match:
-                return False
-
-        return match.group(1).startswith("ASCII text")
+                return (False, "Unreadable file type: '{}'".format(out))
+
+        if "ASCII text" in match.group(1):
+                return (True, "")
+
+        return (False, "File type should be 'ASCII text', was '{}'".format(match.group(1)))
 
 def is_exe(fname):

tests/test.py

@@ -366 +366 @@
                 failed = 0
 
+                # check if the expected files aren't empty
+                if not options.regenerate_expected:
+                        for t in tests:
+                                if is_empty(t.expect()):
+                                        print('WARNING: test "{}" has empty .expect file'.format(t.target()), file=sys.stderr)
+
                 # for each build configurations, run the test
                 with Timed() as total_dur: